Expand sinon peerDep to 17 #909
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you @Techn1x! |
|
any chance for a patch release before the v2 addon format is merged? just in case there's issues with that |
|
IMO it’s straightforward and no issues from my side. |
|
Ya, I'll see if I can get to it on Monday-ish. |
|
Sorry for the delay on this, for some reason I can't download Node 18 locally on my machine, and that's preventing me from running the release-it script. :( Will get this released as soon as I can figure out why that's happening. |
|
Weirdly, Node 16 works but Node 18 doesn't 🙃 |
|
Ok, I think I got a release out? |
|
yep! thanks a bunch! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sinon 17 was released a few days ago
https://github.com/sinonjs/sinon/blob/main/CHANGES.md#1700
Looks like a small release, don't think it'll affect much in this repo & we should allow for it
I've run the test-app locally, all tests pass ✅