Remove namespaced service injections, uninstall ember-cli-deprecation-workflow
#1007
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Unfortunately, it seems the embroider build still fails with these changes. |
|
@elwayman02 I believe it's due to this issue: ember-cli/ember-cli-deprecation-workflow#156 Would you be open to removing |
Ya, that seems fine, given the lack of movement on that issue. |
charlesfries
changed the title
ember-cli-deprecation-workflow
elwayman02
reviewed
Apr 30, 2024
| @@ -2,12 +2,11 @@ import FastBootAwareEventManagerService from 'ember-user-activity/services/-priv | |||
| import Ember from 'ember'; | |||
| import { A } from '@ember/array'; | |||
| import { throttle } from '@ember/runloop'; | |||
| import { inject as injectService } from '@ember/service'; | |||
elwayman02
approved these changes
Apr 30, 2024
|
Thanks for doing this! I'll try to get something released in the next week or so, pending some free time to look at the other outstanding maintenance. |
Closed
|
Sounds great. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #822
I think the potential service name conflicts are a non-issue.