Skip to content

Commit

Permalink
#1: Remove comments about compatibility check with exists Authlibs
Browse files Browse the repository at this point in the history
  • Loading branch information
erickskrauch committed Apr 28, 2019
1 parent 2c7a162 commit 9250d53
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 5 deletions.
2 changes: 0 additions & 2 deletions http/textures.go
Original file line number Diff line number Diff line change
Expand Up @@ -41,14 +41,12 @@ func (cfg *Config) Textures(response http.ResponseWriter, request *http.Request)
} else {
mojangTextures := <-cfg.MojangTexturesQueue.GetTexturesForUsername(username)
if mojangTextures == nil {
// TODO: test compatibility with exists authlibs
response.WriteHeader(http.StatusNoContent)
return
}

texturesProp := mojangTextures.DecodeTextures()
if texturesProp == nil {
// TODO: test compatibility with exists authlibs
response.WriteHeader(http.StatusInternalServerError)
cfg.Logger.Error("Unable to find textures property")
return
Expand Down
4 changes: 1 addition & 3 deletions http/textures_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -189,8 +189,6 @@ func TestConfig_Textures(t *testing.T) {
config.CreateHandler().ServeHTTP(w, req)

resp := w.Result()
assert.Equal(204, resp.StatusCode) // TODO: this is not confirmed behavior
assert.Equal(204, resp.StatusCode)
})
}


0 comments on commit 9250d53

Please sign in to comment.