Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update or change Rollup dependency version range #112

Closed
peterhil opened this issue Feb 28, 2023 · 2 comments · Fixed by #114
Closed

Update or change Rollup dependency version range #112

peterhil opened this issue Feb 28, 2023 · 2 comments · Fixed by #114
Assignees
@elycruz
Labels
bug

Comments

@peterhil
Copy link

When installing or updating dependencies with Pnpm, it nags with the following error since I updated to Rollup 3.17.2.

devDependencies:
- rollup-plugin-sass 1.12.17
+ rollup-plugin-sass 1.12.18

 WARN  Issues with peer dependencies found
.
└─┬ rollup-plugin-sass 1.12.18
  └─┬ @rollup/pluginutils 3.1.0
    └── ✕ unmet peer rollup@^1.20.0||^2.0.0: found 3.17.2

I bet that this plugin will not work with Rollup v1 anymore, and it seems to work with the latest Rollup versions.

Maybe change the Rollup version range on package.json to something like ^2 || ^3? Or then something more specific – there is a npm semantic version calculator by Npm.
@elycruz elycruz self-assigned this Mar 5, 2023
@elycruz elycruz added the bug label Mar 5, 2023
@elycruz
Copy link
Owner

elycruz commented Mar 5, 2023

Thanks for submitting the ticket (ticket assigned). Also - we're going to keep rollup 1.x support, for now, since some users might actually be using that version range.

elycruz added a commit that referenced this issue Mar 5, 2023
@elycruz
fix/#112 - Updated 'rollup', and '@rollup/pluginutils', version range…
a71aec4 
…s to allow an matching version of '@rollup/pluginutils' to be installed alongside 'rollup' v3.

- Removed '@types/rollup', and '@types/sass', from dev-deps due to these not being used in development, since they're just 'stub' packages (their implementation packages export/contain their own typings), and are deprecated, they are safe to removed.
- scripts - Updated 'clean-and-run-downlevel-dts' script, to ignore 'directory not found' warning, when attempting to delete the './ts*' directory, before genating it's new content, since removing the directory, before content generation, is what we're trying to do there.
- gh-actions - Removed unrequired 'github packages' action - We're only publishing to 'npm' for now.
This was referenced Mar 5, 2023
Merged
Merged
@elycruz
Copy link
Owner

elycruz commented Mar 7, 2023

Issue closed automatically, via pull-request lifecycle - Patch performed - Fix is now deployed at package version https://www.npmjs.com/package/rollup-plugin-sass/v/1.12.19 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@elycruz elycruz

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: rollup, and @rollup/pluginutils, version ranges update elycruz/rollup-plugin-sass
2 participants
@peterhil @elycruz