Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typescript: Use sass package option type(s) for SassOptions type #119

Closed
elycruz opened this issue Oct 7, 2023 · 0 comments · Fixed by #120
Closed

Typescript: Use sass package option type(s) for SassOptions type #119

elycruz opened this issue Oct 7, 2023 · 0 comments · Fixed by #120
Assignees
@elycruz
Labels
enhancement triaged Deprecated - Use "groomed" instead.

Comments

@elycruz
Copy link
Owner

elycruz commented Oct 7, 2023

Our SassOptions type is a bit loose, and doesn't take into account the nuances of async, vs sync, and file, and/or, string compilation types.

These are now defined for the sass package (and are included in it's distribution (since version 1.45 (see commit log link below)):

Acceptance Criteria

Use the appropriate type for SassOptions type (LegacyOptions<'async'> type) in defined typescript types.
@elycruz elycruz added enhancement triaged Deprecated - Use "groomed" instead. labels Oct 7, 2023
@elycruz elycruz self-assigned this Oct 7, 2023
elycruz added a commit that referenced this issue Oct 7, 2023
@elycruz
issue-#119 - Updated 'SassOptions' type to use the 'sass' package's one.
5d5bcf8
@elycruz elycruz mentioned this issue Oct 7, 2023
Merged
elycruz added a commit that referenced this issue Oct 7, 2023
@elycruz
issue-#119 - Updated package version.
ca4e47b
elycruz added a commit that referenced this issue Oct 7, 2023
@elycruz
Merge pull request #120 from elycruz/dev
b7ff343 
issue-#119 - Updated 'SassOptions' type to use the 'sass' package's one.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@elycruz elycruz

Labels
enhancement triaged Deprecated - Use "groomed" instead.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

issue-#119 - Updated 'SassOptions' type to use the 'sass' package's one. elycruz/rollup-plugin-sass
1 participant
@elycruz