Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

maintenance: (node fs module) deprecation warnings removal and annotations #111

Merged
merged 2 commits into from
Feb 26, 2023

Conversation

elycruz
Copy link
Owner

@elycruz elycruz commented Feb 26, 2023

Description

  • Removed deprecation warning due to node v18+ deprecating 'fs.rmdir', in '*downlevel-dts', and 'index.test'.
  • Removed the removal of the tmp write file (used in tests) from the 'test.after(...)' - We remove and start a new version of the dir., each time tests run, so no need to remove the dir. afterward.
  • Corrected a test name, and annotated an '@ts-ignore'.
  • Updated package version.

…g 'fs.rmdir', in '*downlevel-dts', and 'index.test'.

- Removed the removal of the tmp write file (used in tests) from the 'test.after(...)' - We remove and start a new version of the dir., each time tests run, so no need to remove the dir. afterward.
- Corrected a test name, and annotated an '@ts-ignore'.
- Updated package version.
@elycruz elycruz self-assigned this Feb 26, 2023
- Added some missing semi-colons.
@elycruz elycruz merged commit c6e45f1 into master Feb 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant