-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#1972 Resolve Error message during validations in Common Properties #1973
Conversation
…n Common Properties Input validation. Signed-off-by: srikant <srksriks123@gmail.com>
@@ -723,7 +723,7 @@ function _validateInput(propertyId, controller, control, showErrors) { | |||
if (isError) { | |||
errorSet = true; | |||
} | |||
} else if (!isError && !errorSet) { | |||
} else if ((!isError && !errorSet) || (!isError && errorSet)) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
errorSet would never be true since the only place it's set to true is in the if part of this block. I'm not sure how this would work.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @matthoward366 It is working in below case
evaluate.mov
So in the first iteration of for (const validation of validations)
errorSet
is set as true
in above condition and in next iteration we are checking if it is true
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good.
…erties (elyra-ai#1973) Signed-off-by: srikant <srksriks123@gmail.com> Co-authored-by: Matt Howard <matthoward366@users.noreply.github.com> Signed-off-by: Michael Pavlik <michael@Michaels-MacBook-Pro.local>
Fixes: #1972
Developer's Certificate of Origin 1.1