Skip to content

Commit

Permalink
Fixes validation when there are pipeline params and default properties (
Browse files Browse the repository at this point in the history
#3195)

Signed-off-by: rkpattnaik780 <rkpattnaik780@gmail.com>
  • Loading branch information
rkpattnaik780 committed May 19, 2024
1 parent 4e7b43d commit bb608d3
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 0 deletions.
2 changes: 2 additions & 0 deletions elyra/cli/pipeline_app.py
Original file line number Diff line number Diff line change
Expand Up @@ -297,6 +297,8 @@ def validate(pipeline_path: str, runtime_config: Optional[str] = None):
except Exception:
raise click.ClickException("Pipeline validation FAILED.")

print_info("Pipeline validation SUCCEEDED.", [])


def validate_timeout_option(ctx, param, value):
"""Callback for monitor-timeout parameter validation"""
Expand Down
3 changes: 3 additions & 0 deletions elyra/pipeline/pipeline_definition.py
Original file line number Diff line number Diff line change
Expand Up @@ -265,6 +265,9 @@ def convert_pipeline_parameters(self, runtime_type_name: str) -> None:
if parameter_class is None:
return None # runtime type does not support parameters, skip

if not ElyraProperty.subclass_exists_for_property(parameter_class.property_id):
ElyraProperty.build_property_map()

# Convert pipeline parameters to runtime-specific instances
converted_value = ElyraProperty.create_instance(parameter_class.property_id, self.pipeline_parameters)
if converted_value is not None:
Expand Down

0 comments on commit bb608d3

Please sign in to comment.