Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing the Editor Theme doesn't change the Python Editor theme #127

Closed
lresende opened this issue Oct 26, 2019 · 5 comments · Fixed by #595
Closed

Changing the Editor Theme doesn't change the Python Editor theme #127

lresende opened this issue Oct 26, 2019 · 5 comments · Fixed by #595
Assignees
Labels
component:python-editor Python editor help wanted Extra attention is needed kind:bug Something isn't working

Comments

@lresende
Copy link
Member

When using the Setting's menu to change the theme for the Text Editor it does not apply to the Python Editor.

@lresende lresende added kind:bug Something isn't working future component:python-editor Python editor labels Oct 26, 2019
@lresende
Copy link
Member Author

author: @ajbozarth
The theme seems to be handled by codeeditor not fileeditor so there may be other functionality missing that is also handled in the same location. This should be investigated alongside this issue.

@kinow
Copy link

kinow commented Mar 11, 2020

The python editor seems to be working fine for me when I switched to dark mode.

image

And also switching to the default theme and increasing font size.

image

@ajbozarth
Copy link
Member

Thanks for checking into this, it seems some of our recent work has made some of the codeditor features like dark theme start working without realizing it.

@ajbozarth
Copy link
Member

Though python editor seems to work ok, other parts of elyra don't support dark mode. I'm going to use this issue to track addressing elyra dark mode over all. I plan to work on this myself, but if a new dev would like to take it if before I get to it that's ok as well. I'll make sure to post here when I actually start work on this. Afaik the side bar icons and side bar widgets all need to be updated for dark mode support, as well as pipeline editor.

@ajbozarth ajbozarth self-assigned this Jun 9, 2020
@ajbozarth ajbozarth added the help wanted Extra attention is needed label Jun 9, 2020
@ajbozarth
Copy link
Member

Since #595 addresses the original intent of this PR, that is that code mirror functionality was missing. I opened #625 to handle general dark mode support

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:python-editor Python editor help wanted Extra attention is needed kind:bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants