-
Notifications
You must be signed in to change notification settings - Fork 331
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mirror PythonFileEditor and Editor trackers #595
Conversation
After doing some investigation, I found that our python editor never sets its own session, which represents a live connection to a session kernel, basically a manager that owns the kernel. In our current implementation, we create a python kernel and manually runs/stops it, only reading the input once at runtime, and exposing the output when it's done, there is never a live session running (removing the shutdown command after a run is not enough) - hence the option to create a python editor console is disabled from our extension. |
f4d5bd2
to
09a4e51
Compare
Instead of re-implementing the auto-complete on python file editor, the team agreed in enabling the existing 'Create console for editor'. The create console command was being disabled in python editor because the condition coming from fileeditor-extension was
And it was found that |
mirroring the editor tracker has made some code redunant
I've pushed an update removing redundant code that is no longer needed once we mirror the PythonEditor tracker with the Editor tracker. I've also updated the title and description for this PR to match the broader scope of this fix, as it now address multiple Issues. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Including my updates I've tested this and it addresses all the missing features mentioned. LGTM
As per the doc and previous work by @karlaspuldaro we should use `inject` rather than add. This change requires the addition of a missing css selector for the context menu to still work though.
copying my last commit message her for reference:
|
Using |
This reverts commit cef76a6.
Upon further testing and research I've reverted my last commit that switched to inject. As @karlaspuldaro previously mentioned the FileEditor widget includes a check against |
Applying "Jupyterlab 1.x" as this needs backport to 1.x branch. I have started the backport but needs a little more work as TOC stopped working (we might need a smaller cleanup on 1.x than in 2.x). |
This tracker change fixes multiple PythonEditor issues: - Enable autocomplete to work on PythonEditor when using a console (similar to JupyterLab text editor) - Fix TOC integration with Python Editor - Fix Editor theme with PythonEditor - Enable JupyterLab search with Python Editor Co-authored-by: Alex Bozarth <ajbozart@us.ibm.com>
This tracker change fixes multiple PythonEditor issues: - Enable autocomplete to work on PythonEditor when using a console (similar to JupyterLab text editor) - Fix TOC integration with Python Editor - Fix Editor theme with PythonEditor - Enable JupyterLab search with Python Editor Co-authored-by: Alex Bozarth <ajbozart@us.ibm.com>
Fixes #586
Fixes #520
Fixes #230
Fixes #127
Enables Create New Console for Editor from the context menu (right-click on the editor).
With the console running, auto-complete feature is accessible from the editor as below:
Enables TOC's python generator to work by default via the Editor tracker
Enables all FileEditor feature that are ties to it's tracker, including:
Developer's Certificate of Origin 1.1