[Imported PR] [WIP] Added activate utils to python runner

[lresende]

The utils.ts file will eventually be removed and called from jupyterlab

[lresende]

author: @ajbozarth
@lresende He's the code I have that I can't get to build outside JupyterLab. The utils.ts file works when used by fileeditor-extension in JupyterLab but not outside in our code, I've tried all the cleanup I can and it just won't work for me :(

[lresende]

author: @ajbozarth
For reference here's my errors I get:

/Users/ajbozart/workspace/jupyter/ai-workspace/packages/python-runner/src/utils.ts
Error:(140, 35) TS2345: Argument of type '(key: "wordWrapColumn" | "fontFamily" | "fontSize" | "lineHeight" | "lineNumbers" | "lineWrap" | "readOnly" | "tabSize" | "insertSpaces" | "matchBrackets" | "autoClosingBrackets" | "rulers" | "codeFolding") => void' is not assignable to parameter of type '(value: string, index: number, array: string[]) => void'.
  Types of parameters 'key' and 'value' are incompatible.
    Type 'string' is not assignable to type '"wordWrapColumn" | "fontFamily" | "fontSize" | "lineHeight" | "lineNumbers" | "lineWrap" | "readOnly" | "tabSize" | "insertSpaces" | "matchBrackets" | "autoClosingBrackets" | "rulers" | "codeFolding"'.
Error:(573, 33) TS2345: Argument of type 'IUndoer<IDocumentWidget<FileEditor, IModel>>' is not assignable to parameter of type 'IUndoer<Widget>'.
  Types of property 'undo' are incompatible.
    Type '(widget: IDocumentWidget<FileEditor, IModel>) => void' is not assignable to type '(widget: Widget) => void'.
      Types of parameters 'widget' and 'widget' are incompatible.
        Type 'Widget' is not assignable to type 'IDocumentWidget<FileEditor, IModel>'.
Error:(584, 39) TS2345: Argument of type 'IEditorViewer<IDocumentWidget<FileEditor, IModel>>' is not assignable to parameter of type 'IEditorViewer<Widget>'.
  Types of property 'toggleLineNumbers' are incompatible.
    Type '(widget: IDocumentWidget<FileEditor, IModel>) => void' is not assignable to type '(widget: Widget) => void'.
      Types of parameters 'widget' and 'widget' are incompatible.
        Type 'Widget' is not assignable to type 'IDocumentWidget<FileEditor, IModel>'.
Error:(610, 41) TS2345: Argument of type 'IConsoleCreator<IDocumentWidget<FileEditor, IModel>>' is not assignable to parameter of type 'IConsoleCreator<Widget>'.
  Types of property 'createConsole' are incompatible.
    Type '(widget: IDocumentWidget<FileEditor, IModel>) => Promise<void>' is not assignable to type '(widget: Widget) => Promise<void>'.
      Types of parameters 'widget' and 'widget' are incompatible.
        Type 'Widget' is not assignable to type 'IDocumentWidget<FileEditor, IModel>'.
Error:(617, 36) TS2345: Argument of type 'ICodeRunner<IDocumentWidget<FileEditor, IModel>>' is not assignable to parameter of type 'ICodeRunner<Widget>'.
  Types of property 'run' are incompatible.
    Type '(widget: IDocumentWidget<FileEditor, IModel>) => Promise<void>' is not assignable to type '(widget: Widget) => Promise<void>'.
      Types of parameters 'widget' and 'widget' are incompatible.
        Type 'Widget' is not assignable to type 'IDocumentWidget<FileEditor, IModel>'.

copied from my ide console for easier readability that the terminal output (which has diff's mixed in)

[lresende]

author: @ajbozarth
also @karlaspuldaro if you want to try and see if it works for you :/

[lresende]

author: @lresende
@ajbozart I believe your changes are trying to handle much more than needed, e.g. supporting tracker by extending IEditorTracker which might not completely work in our scenario. At this point, how about you open an issue or start some discussion on Gitter stating your requirements and see if we can get some feedback or suggestions?

[lresende]

author: @lresende
btw, I do see the same issues you mentioned above

[lresende]

author: @ajbozarth
Open issue on JupyterLab for this problem: jupyterlab/jupyterlab#6901 (as suggested in the gitter)

[lresende]

author: @ajbozarth
Open PR based on the discussion in the above issue: jupyterlab/jupyterlab#6904

[lresende]

author: @akchinSTC
jupyterlab/jupyterlab#6904
PR has been merged...yay!
Is this PR tracked in any of the current issues we have open?

[lresende]

author: @ajbozarth
Once I finish my current work on common properties I will return to this PR and update to use the recently merged functionality. And I believe there is a tracking issue in zenhub, but not this repo

[lresende]

author: @ajbozarth
Given how much has changed since I last worked on this PR I am going to close and abandon it and start from scratch