New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update kfp component files to include optional parameter #1854
Conversation
Thanks for making a pull request to Elyra! To try out this branch on binder, follow this link: |
elyra/pipeline/resources/kfp/kubeflow_serve_model_using_kfserving/component.yaml
Outdated
Show resolved
Hide resolved
elyra/pipeline/resources/kfp/filter_text_using_shell_and_grep/component.yaml
Outdated
Show resolved
Hide resolved
Could we add a comment at the beginning of each example component file:
|
0605ec5
to
1a18a1a
Compare
@akchinSTC Could you please update the license and list the origin + license of these component files |
elyra/pipeline/resources/kfp/filter_text_using_shell_and_grep/component.yaml
Show resolved
Hide resolved
1933b69
to
18bc72b
Compare
18bc72b
to
01f2c3c
Compare
@akchinSTC @kiersten-stokes Could you please resolve conflicts. |
0c8f6ea
to
5c33c8e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the linting issue below is the only outstanding thing for this PR (I say as if I didn't introduce the problem...)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to make the registry aware of the additional location where components are located either by convention and/or by explicitly adding things on the registry JSON with the proper type and not let a reader calculate the location based on the type of the runtime, because then that reader looses its flexibility
d024ae5
to
dcfc59b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Tested an example for each runtime and each succeeded
Update the kfp component definitions to align with best practices and include descriptions and source license information
- Omit new fields from component properties in pipeline parser - Change integration test to reference new component name - Remove runtime type from reader abstract method
a0e2c8c
to
d4e7758
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure if for file-based directory of components we need to list one by one in the registry, but for this PR I guess it's ok to avoid delays, but we will need to revisit this in the future.
and include descriptions and source license information
What changes were proposed in this pull request?
How was this pull request tested?
Developer's Certificate of Origin 1.1