Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update operation naming for airflow custom components #1961

Merged
merged 1 commit into from Jul 27, 2021

Conversation

akchinSTC
Copy link
Member

Current naming calls for a timestamp which could still
present naming conflicts on a fast system. This change
will ensure a unique suffix is generated.

What changes were proposed in this pull request?

How was this pull request tested?

Developer's Certificate of Origin 1.1

   By making a contribution to this project, I certify that:

   (a) The contribution was created in whole or in part by me and I
       have the right to submit it under the Apache License 2.0; or

   (b) The contribution is based upon previous work that, to the best
       of my knowledge, is covered under an appropriate open source
       license and I have the right under that license to submit that
       work with modifications, whether created in whole or in part
       by me, under the same open source license (unless I am
       permitted to submit under a different license), as indicated
       in the file; or

   (c) The contribution was provided directly to me by some other
       person who certified (a), (b) or (c) and I have not modified
       it.

   (d) I understand and agree that this project and the contribution
       are public and that a record of the contribution (including all
       personal information I submit with it, including my sign-off) is
       maintained indefinitely and may be redistributed consistent with
       this project or the open source license(s) involved.

Current naming calls for a timestamp which could still
present naming conflicts on a fast system. This change
will ensure a unique suffix is generated.
@elyra-bot
Copy link

elyra-bot bot commented Jul 26, 2021

Thanks for making a pull request to Elyra!

To try out this branch on binder, follow this link: Binder

@akchinSTC akchinSTC added this to the 3.0.0 milestone Jul 26, 2021
@akchinSTC akchinSTC requested a review from ptitzler July 26, 2021 21:33
Copy link
Member

@ptitzler ptitzler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for custom and generic components

@lresende lresende added platform: pipeline-Airflow Related to usage of Apache Airflow as pipeline runtime and removed approved labels Jul 27, 2021
@lresende lresende merged commit b2d0aec into elyra-ai:master Jul 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
platform: pipeline-Airflow Related to usage of Apache Airflow as pipeline runtime
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants