Improve validation output in elyra-pipeline CLI #2070
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR:
The proposed output introduces a new generic message display "pattern", comprising
[validation-issue-severity]
- always displayed[node-label]
- displayed if applicable and available[property-name]
- displayed if applicable and available- <validation-message-text>
- always displayedMessages are sorted by severity (error > warning > ...), enabling the user to quickly locate issues that cause the operation to be aborted.
For clarity each component could be prefixed, but that would result in a lot more "static" output.
Example output without prefixes:
Example output with prefixes:
How was this pull request tested?
Reviewed output for the following scenarios
validation output (no errors or warnings)
run command
validation output (errors but no warnings)
run command
validation output (warnings only)
run command
validation output (no errors or warnings)
submit command
validation output (errors but no warnings)
submit command
validation output (warnings only)
submit command
verify that validation changes don't break VPE output
Fixes #1999
Developer's Certificate of Origin 1.1