New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set 'EnumControl' property values to 'null' in properties JSON #2432
Set 'EnumControl' property values to 'null' in properties JSON #2432
Conversation
Co-authored-by: Martha Cryan <martha.cryan@ibm.com>
Thanks for making a pull request to Elyra! To try out this branch on binder, follow this link: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested locally and this LGTM, my only question is should we cut the pipeline-editor release and update it here or merge this and use a follow up to cut release and update it closer to elyra 3.6 final release? (opinions @akchinSTC ?)
I have no preference! Probably easiest just to do it here if no objections |
Related to elyra-ai/pipeline-editor#186
What changes were proposed in this pull request?
Changes the default value of
runtime_image
tonull
in the generic properties template. This property is our only recurringEnumControl
property for generic components. For custom components, we haven't run into a situation whereEnumControl
is used, but I've added a simpleif/else
block to the custom component properties template to account for that situation should it show up in the future.How was this pull request tested?
Updates one relevant backend test resource.
Updates one relevant integration test snapshot resource.
Developer's Certificate of Origin 1.1