Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set 'EnumControl' property values to 'null' in properties JSON #2432

Merged
merged 8 commits into from Feb 7, 2022

Conversation

kiersten-stokes
Copy link
Member

@kiersten-stokes kiersten-stokes commented Feb 1, 2022

Related to elyra-ai/pipeline-editor#186

What changes were proposed in this pull request?

Changes the default value of runtime_image to null in the generic properties template. This property is our only recurring EnumControl property for generic components. For custom components, we haven't run into a situation where EnumControl is used, but I've added a simple if/else block to the custom component properties template to account for that situation should it show up in the future.

How was this pull request tested?

Updates one relevant backend test resource.
Updates one relevant integration test snapshot resource.

Developer's Certificate of Origin 1.1

   By making a contribution to this project, I certify that:

   (a) The contribution was created in whole or in part by me and I
       have the right to submit it under the Apache License 2.0; or

   (b) The contribution is based upon previous work that, to the best
       of my knowledge, is covered under an appropriate open source
       license and I have the right under that license to submit that
       work with modifications, whether created in whole or in part
       by me, under the same open source license (unless I am
       permitted to submit under a different license), as indicated
       in the file; or

   (c) The contribution was provided directly to me by some other
       person who certified (a), (b) or (c) and I have not modified
       it.

   (d) I understand and agree that this project and the contribution
       are public and that a record of the contribution (including all
       personal information I submit with it, including my sign-off) is
       maintained indefinitely and may be redistributed consistent with
       this project or the open source license(s) involved.

@elyra-bot
Copy link

elyra-bot bot commented Feb 1, 2022

Thanks for making a pull request to Elyra!

To try out this branch on binder, follow this link: Binder

@akchinSTC akchinSTC self-requested a review February 3, 2022 22:25
@ajbozarth ajbozarth added this to the 3.6.0 milestone Feb 3, 2022
Copy link
Member

@akchinSTC akchinSTC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

Copy link
Member

@ajbozarth ajbozarth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally and this LGTM, my only question is should we cut the pipeline-editor release and update it here or merge this and use a follow up to cut release and update it closer to elyra 3.6 final release? (opinions @akchinSTC ?)

@kiersten-stokes
Copy link
Member Author

Tested locally and this LGTM, my only question is should we cut the pipeline-editor release and update it here or merge this and use a follow up to cut release and update it closer to elyra 3.6 final release?

I have no preference! Probably easiest just to do it here if no objections

@akchinSTC akchinSTC merged commit 58540f7 into elyra-ai:master Feb 7, 2022
@kiersten-stokes kiersten-stokes deleted the remove-empty-string branch April 1, 2022 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants