Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Jinja2 dependencies #2589

Merged
merged 2 commits into from
Mar 25, 2022
Merged

Conversation

akchinSTC
Copy link
Member

@akchinSTC akchinSTC commented Mar 24, 2022

See pallets/jinja/issues/1629

Breaking changes were introduced in jinja2 3.1.0, so we will need to cap it both here and in our bootstrapper requirements for generic components.

This is a partial fix for #2586 until https://github.com/jupyter/nbconvert/pull/1737/files get cut into a release.

What changes were proposed in this pull request?

How was this pull request tested?

example pipelines were run against this branch. jinja2 resolves to correct version in container
image

Developer's Certificate of Origin 1.1

   By making a contribution to this project, I certify that:

   (a) The contribution was created in whole or in part by me and I
       have the right to submit it under the Apache License 2.0; or

   (b) The contribution is based upon previous work that, to the best
       of my knowledge, is covered under an appropriate open source
       license and I have the right under that license to submit that
       work with modifications, whether created in whole or in part
       by me, under the same open source license (unless I am
       permitted to submit under a different license), as indicated
       in the file; or

   (c) The contribution was provided directly to me by some other
       person who certified (a), (b) or (c) and I have not modified
       it.

   (d) I understand and agree that this project and the contribution
       are public and that a record of the contribution (including all
       personal information I submit with it, including my sign-off) is
       maintained indefinitely and may be redistributed consistent with
       this project or the open source license(s) involved.

@elyra-bot
Copy link

elyra-bot bot commented Mar 24, 2022

Thanks for making a pull request to Elyra!

To try out this branch on binder, follow this link: Binder

@akchinSTC akchinSTC added component:build build and build related issues(dependencies and docker) dependencies Pull requests that update a dependency file labels Mar 24, 2022
@akchinSTC akchinSTC linked an issue Mar 24, 2022 that may be closed by this pull request
@akchinSTC akchinSTC removed a link to an issue Mar 24, 2022
Copy link
Member

@kevin-bates kevin-bates left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks Alan!

@akchinSTC akchinSTC merged commit 1aba94f into elyra-ai:master Mar 25, 2022
@lresende lresende added this to the 3.7.0 milestone Mar 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:build build and build related issues(dependencies and docker) dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants