New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update linting to use black formatter #2618
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reformatted elyra root directory with black formatter
Added black to lint-server Make target
Added pyproject.toml (Black only supports use of toml)
Added black and click to lint requirements, recent release of click 8.1.0 is causing black to fail
Flake8 conflicts that appear after black reformatting, should we ignore in flake8 or add rules to black to not do this? See https://github.com/elyra-ai/elyra/runs/5776010612?check_suite_focus=true
What changes were proposed in this pull request?
This PR introduces the use of
black
to thelint-server
target of theMakefile
(in conjunction with the existingflake8
pass) in order to produce a consistent code style throughout the python code.We've also used this (one-time) opportunity to convert formatted strings (e.g.,
"{}".format(foo)
) to f-strings (e.g.,f"{foo}"
). This particular "convention" will continue to be enforced via the review process.How was this pull request tested?
Developer's Certificate of Origin 1.1