Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix container image build issues for official releases #2845

Merged
merged 2 commits into from Jul 25, 2022

Conversation

ptitzler
Copy link
Member

@ptitzler ptitzler commented Jul 21, 2022

Closes #2841

What changes were proposed in this pull request?

  • Perform a conditional copy of the wheel file instead of an unconditional one, which caused the container image builds to fail for official releases

How was this pull request tested?

Create container images from source code:

  • git clone git@github.com:ptitzler/elyra.git
  • cd elyra
  • git checkout fix-docker-build
  • Run make install (this is a current limitation unrelated to the issue this PR is addressing)
  • Run make container-images (success)

Create container images from published packages:

  • git clone git@github.com:elyra-ai/elyra.git into a different directory
  • cd elyra
  • git checkout tags/v3.10.1. # switch to a release tag (which does not yet contain the changes from this PR)
  • copy etc/docker/kubeflow/Dockerfile (from this PR) to the same location in ^^
  • copy etc/docker/kubeflow/Dockerfile (from this PR) to the same location in ^^
  • Run make container-images (success)

Developer's Certificate of Origin 1.1

   By making a contribution to this project, I certify that:

   (a) The contribution was created in whole or in part by me and I
       have the right to submit it under the Apache License 2.0; or

   (b) The contribution is based upon previous work that, to the best
       of my knowledge, is covered under an appropriate open source
       license and I have the right under that license to submit that
       work with modifications, whether created in whole or in part
       by me, under the same open source license (unless I am
       permitted to submit under a different license), as indicated
       in the file; or

   (c) The contribution was provided directly to me by some other
       person who certified (a), (b) or (c) and I have not modified
       it.

   (d) I understand and agree that this project and the contribution
       are public and that a record of the contribution (including all
       personal information I submit with it, including my sign-off) is
       maintained indefinitely and may be redistributed consistent with
       this project or the open source license(s) involved.

@ptitzler ptitzler added kind:bug Something isn't working component:build build and build related issues(dependencies and docker) labels Jul 21, 2022
@ptitzler ptitzler added this to the 3.11.0 milestone Jul 21, 2022
@elyra-bot
Copy link

elyra-bot bot commented Jul 21, 2022

Thanks for making a pull request to Elyra!

To try out this branch on binder, follow this link: Binder

@ptitzler ptitzler changed the title Fix Dockerfiles Fix container image build issues for official releases Jul 21, 2022
Co-authored-by: Kevin Bates <kbates4@gmail.com>
Copy link
Member

@kevin-bates kevin-bates left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for solidifying this @ptitzler!

Copy link
Member

@kiersten-stokes kiersten-stokes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working like a charm!

@akchinSTC akchinSTC merged commit 2c57b03 into elyra-ai:main Jul 25, 2022
@ptitzler ptitzler deleted the fix-docker-build branch July 25, 2022 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:build build and build related issues(dependencies and docker) kind:bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

'make elyra-image' and 'make kf-notebook-image' fail
4 participants