Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow users to include ssl_sa_certs via env vars for kfp_tekton client #3150

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions elyra/pipeline/kfp/kfp_authentication.py
Original file line number Diff line number Diff line change
Expand Up @@ -230,6 +230,7 @@ def authenticate(
"""

kf_url = urlsplit(api_endpoint)._replace(path="").geturl()
kf_pipelines_ssl_sa_cert = os.getenv("KF_PIPELINES_SSL_SA_CERTS", None)

# return data structure for successful requests
auth_info = {
Expand All @@ -239,6 +240,7 @@ def authenticate(
"cookies": None, # passed to KFP SDK client as "cookies" param value
"credentials": None, # passed to KFP SDK client as "credentials" param value
"existing_token": None, # passed to KFP SDK client as "existing_token" param value
"ssl_ca_cert": kf_pipelines_ssl_sa_cert, # passed to KFP SDK Client as "ssl_ca_cert" param value
}

try:
Expand Down
1 change: 1 addition & 0 deletions elyra/pipeline/kfp/processor_kfp.py
Original file line number Diff line number Diff line change
Expand Up @@ -213,6 +213,7 @@ def process(self, pipeline):
credentials=auth_info.get("credentials", None),
existing_token=auth_info.get("existing_token", None),
namespace=user_namespace,
ssl_ca_cert=auth_info.get("ssl_ca_cert", None),
)
else:
client = ArgoClient(
Expand Down
Loading