Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip minio-7.2.1 to avoid urllib version mismatch #3204

Merged
merged 1 commit into from
Dec 28, 2023

Conversation

savemuri
Copy link
Contributor

@savemuri savemuri commented Dec 28, 2023

Fixes #3203

What changes were proposed in this pull request?

Skipping minio version 7.2.1 to avoid urllib version conflict. Refer #3203 for more info.

How was this pull request tested?

Tested by running

make install
make kf-notebook-image
docker run -p 8888:8888 docker.io/elyra/kf-notebook:dev

Developer's Certificate of Origin 1.1

   By making a contribution to this project, I certify that:

   (a) The contribution was created in whole or in part by me and I
       have the right to submit it under the Apache License 2.0; or

   (b) The contribution is based upon previous work that, to the best
       of my knowledge, is covered under an appropriate open source
       license and I have the right under that license to submit that
       work with modifications, whether created in whole or in part
       by me, under the same open source license (unless I am
       permitted to submit under a different license), as indicated
       in the file; or

   (c) The contribution was provided directly to me by some other
       person who certified (a), (b) or (c) and I have not modified
       it.

   (d) I understand and agree that this project and the contribution
       are public and that a record of the contribution (including all
       personal information I submit with it, including my sign-off) is
       maintained indefinitely and may be redistributed consistent with
       this project or the open source license(s) involved.

Signed-off-by: Sasank Vemuri <sasankv@nvidia.com>
Copy link
Member

@lresende lresende left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, waiting for green build

@lresende lresende merged commit 4ecea25 into elyra-ai:main Dec 28, 2023
17 checks passed
@lresende lresende added this to the 4.0.0 milestone Jan 12, 2024
D3f0 pushed a commit to D3f0/elyra that referenced this pull request Mar 8, 2024
Signed-off-by: Sasank Vemuri <sasankv@nvidia.com>
Co-authored-by: Sasank Vemuri <sasankv@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Local development setup not working
2 participants