Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

children prop is causing some type errors although it works correctly in runtime #10

Closed
joetifa2003 opened this issue Sep 10, 2023 · 6 comments · Fixed by #20
Closed

Comments

@joetifa2003
Copy link

image

@ethanniser
Copy link

image
kitajs/html has types that should solve this
we just need to reexport them

@arthurfiorette
Copy link
Contributor

arthurfiorette commented Sep 10, 2023

Hey @ethanniser & @SaltyAom. I was looking through the source code and seems that there are things that can better integrate with @kitajs/html and how JSX works in general...

Would you mind on me opening a PR to improve them?

I do think that the safe mode should be more relevant inside the documentation. We don't want to go back to these old XSS php days.

Also, maybe we should work on re-use jsx.d.ts from @kitajs/html, duplicity would be bad here as it is a very long declaration file which could hide features/tags. (I did improve declarations in this latest release)

@joetifa2003
Copy link
Author

import { PropsWithChildren } from "@kitajs/html";

I added the package as a dep just to import the type, because i found no way to import this from Elysia html

@joetifa2003
Copy link
Author

Also i don't see a way to call @kitajs/html compile from this plugin

@ethanniser
Copy link

The plugin is just a couple days out of date with kita, if someone wants to make a pr it would not be that hard.

I might be able to later tonight

@arthurfiorette
Copy link
Contributor

PR is already being done at #13

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants