Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Connectors and pipes don't connect visually to the blocks #14

Open
calloatti opened this issue Feb 2, 2018 · 9 comments
Open

Connectors and pipes don't connect visually to the blocks #14

calloatti opened this issue Feb 2, 2018 · 9 comments

Comments

@calloatti
Copy link

calloatti commented Feb 2, 2018

  • The version of the mod you are using BetterBoilers-1.1.1
  • Your Minecraft version 1.12.2
  • Your Forge version 14.23.1.2594

They work, but don't connect visually:

(Edit: I changed some of the textures)

2018-02-02_20 21 40
2018-02-02_20 23 11
2018-02-02_20 23 18

@LemmaEOF
Copy link
Member

LemmaEOF commented Feb 3, 2018

I am aware of this issue, and I'm afraid it's very much a cantfix as far as I know.

The way that the valve, vent, pump, and hatch work is that they act as a proxy for the CapabilityFluidStorage or CapabilityItemStorage for the boiler controller. When separate from the multiblock, they don't have a capability, period. However, because of the proxy nature, they still for some reason don't connect up to pipes. I'm gonna have to check with some other devs I know to see if they know how to solve this.

@calloatti
Copy link
Author

Even when part of the multiblock they don't connect, as you mentioned.

This mod seems to do it right:

2018-02-02_21 14 10

Maybe you could check out their code.

https://github.com/CyclopsMC/CapabilityProxy
https://minecraft.curseforge.com/projects/capabilityproxy

@LemmaEOF
Copy link
Member

LemmaEOF commented Feb 3, 2018

Oh boy, Cyclops. Pretty much all of Cyclops' capability stuff is his own witchcraft from CyclopsCore, so I'll see what I can do.

@DaedalusGame
Copy link

could it be that this is a client-side issue? controller could be null on the client, which causes it to not return a capability?

@LemmaEOF
Copy link
Member

LemmaEOF commented May 1, 2018

Hm, that could be something to test. I'll take a look when I have the time.

@pupnewfster
Copy link

pupnewfster commented Jun 2, 2019

Not quite sure if this is the same thing, but this is the same as how for example after restarting the server pipes get disconnected... Then I believe the issue may just be that as you said, since the proxy blocks do not have a capability unless they are part of the multiblock, that once they become part of a valid multiblock (and have a capability) they do not send a neighbor notify update to inform the pipes to recheck if they can connect.

@LemmaEOF
Copy link
Member

LemmaEOF commented Jun 2, 2019

That actually might be it. I might have them expose a dummy cap until they get connected.

@pupnewfster
Copy link

pupnewfster commented Jun 3, 2019

The other option is assuming your setController method gets called both when it is unsetting and when it is setting it again, you could then just call notify neighbor/on neighbor change there.

@DrUltraLux
Copy link
Collaborator

This will be fixed in the next commit now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants