Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Boot2docker #2

Merged
merged 3 commits into from
Jul 9, 2014
Merged

Boot2docker #2

merged 3 commits into from
Jul 9, 2014

Conversation

asher
Copy link
Contributor

@asher asher commented Jul 7, 2014

I'm running knife under os x, with boot2docker (https://github.com/boot2docker/boot2docker) as my local interface to docker. This makes knife-docker usable in this environment.

container_info = `docker inspect #{id}`
ip = container_info.match(/"IPAddress": "([\d\.]+)"/)[1]
# if using boot2docker, get server ip and forwarded container ssh port
if config[:boot2docker] == true
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"== true" seems pleonastic. :-)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll axe it, thanks!

ema added a commit that referenced this pull request Jul 9, 2014
@ema ema merged commit a87bf13 into ema:master Jul 9, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants