Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

circe-display-NICK (thoughts on) #38

Open
retroj opened this issue Nov 22, 2012 · 3 comments
Open

circe-display-NICK (thoughts on) #38

retroj opened this issue Nov 22, 2012 · 3 comments
Assignees
Milestone

Comments

@retroj
Copy link
Collaborator

retroj commented Nov 22, 2012

I wonder if the nick change message can be shortened any, and reviewing circe-display-NICK, two questions occurred to me:

  1. Do we really need to show the user's host mask for this type of message?
  2. When you change your own nick, why is there one message format for the server buffer, but a different message format for channel buffers?

Discuss :)

@jorgenschaefer
Copy link
Collaborator

  1. Yes, makes identifying (ab-)users easier, especially on networks without nickserv. But we can move it to the end of the message, if that makes it better.

  2. IIRC, because it would have required an additional condition in the channel buffer loop. ;-) We can change the server buffer format to be consistent if we like.

@retroj
Copy link
Collaborator Author

retroj commented Nov 23, 2012

I think the message in the server buffer is good. We might want to put that conditional into the channel buffer loop, though.

In lieu of changing the default message format, I would like to be able to customize it, to remove the host mask on my system. I could override the entire handler, but in this case it is such a large procedure that I think perhaps the strings should be individually customizable.

@jorgenschaefer
Copy link
Collaborator

In theory, I think we should have format strings for all messages Circe emits. So yes, please extract the format string into a variable and use that.

@ghost ghost assigned retroj Mar 3, 2013
@jorgenschaefer jorgenschaefer modified the milestones: Release v1.4, Release 1.5 Aug 26, 2014
@jorgenschaefer jorgenschaefer modified the milestones: Release v1.5, v1.6 Dec 12, 2014
@jorgenschaefer jorgenschaefer modified the milestones: v1.7, v1.6 Feb 21, 2015
@jorgenschaefer jorgenschaefer modified the milestones: v1.8, v1.7 Apr 4, 2015
@jorgenschaefer jorgenschaefer modified the milestones: Backlog, v2.1 Nov 1, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants