Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add citar-add-library-file #528

Closed
bdarcus opened this issue Jan 11, 2022 · 3 comments · Fixed by #562
Closed

Add citar-add-library-file #528

bdarcus opened this issue Jan 11, 2022 · 3 comments · Fixed by #562

Comments

@bdarcus
Copy link
Contributor

bdarcus commented Jan 11, 2022

I added a modified, more general, version of this to the wiki. I may add it back to citar; I just wasn't sure if anyone used this ;-)

https://github.com/bdarcus/citar/wiki/Example-functions#add-file-to-library

There's still a little bug in it that I'll fix.

It uses completing-read rather than completing-read-multiple, and works on any file.

Note: recent changes in many of these commands are designed to make them compatible with embark-act-all. I'm not sure the UI on the current version of this command actually is, seems it seems to prompt you to rename the file in one case. Worth testing this.

It also occurs to me that we might want to include an option to add from a DOI, which maybe does that without prompting if the entry has a DOI?

Originally posted by @bdarcus in #522 (reply in thread)

@suyashbire1
Copy link

Hi, thank you for this very useful package!

I recently switched to vertico from ivy. I used this feature very frequently with ivy-bibtex so it would be useful to have it in citar as well. Thank you very much!

Also, note that file-name-concat function requires emacs version 28.1. It wasn't working for me in 27.2. Just putting it out there if someone else is facing the same issue.

It also occurs to me that we might want to include an option to add from a DOI, which maybe does that without prompting if the entry has a DOI?

You mean add a pdf? That would be cool!
If you mean add bibtex entry from doi, biblio already has a similar function.

@bdarcus
Copy link
Contributor Author

bdarcus commented Jan 16, 2022

You mean add a pdf?

I did mean this.

bdarcus added a commit that referenced this issue Mar 24, 2022
Replace the original pdf-oriented function with a more general one.

Close #528
@bdarcus
Copy link
Contributor Author

bdarcus commented Mar 24, 2022

For folks interested in this, care to test #562, which I have not yet done?

If you do, please try it with files with different extensions.

cc @apc

bdarcus added a commit that referenced this issue Mar 24, 2022
Replace the original pdf-oriented function with a more general one.

Close #528
bdarcus added a commit that referenced this issue Mar 24, 2022
Replace the original pdf-oriented function with a more general one.

Close #528
bdarcus added a commit that referenced this issue Mar 28, 2022
Replace the original pdf-oriented function with a more general one.

Close #528
bdarcus added a commit that referenced this issue Apr 1, 2022
Replace the original pdf-oriented function with a more general one.

Close #528
bdarcus added a commit that referenced this issue May 14, 2022
Replace the original pdf-oriented function with a more general one.

Close #528
bdarcus added a commit that referenced this issue May 14, 2022
Replace the original pdf-oriented function with a more general one.

Close #528
bdarcus added a commit that referenced this issue May 14, 2022
Replace the original pdf-oriented function with a more general one.

Close #528
bdarcus added a commit that referenced this issue May 14, 2022
Replace the original pdf-oriented function with a more general one.

Close #528
bdarcus added a commit that referenced this issue May 14, 2022
Replace the original pdf-oriented function with a more general one.

Close #528
bdarcus added a commit that referenced this issue May 14, 2022
Replace the original pdf-oriented function with a more general one.

Close #528
bdarcus added a commit that referenced this issue May 15, 2022
Replace the original pdf-oriented function with a more general one.

Close #528
bdarcus added a commit that referenced this issue May 15, 2022
Replace the original pdf-oriented function with a more general one.

Close #528
bdarcus added a commit that referenced this issue May 15, 2022
Replace the original pdf-oriented function with a more general one.

Close #528
bdarcus added a commit that referenced this issue May 15, 2022
Replace the original pdf-oriented function with a more general one.

Close #528
bdarcus added a commit that referenced this issue May 15, 2022
Replace the original pdf-oriented function with a more general one.

Close #528
bdarcus added a commit that referenced this issue May 15, 2022
Replace the original pdf-oriented function with a more general one.

Close #528
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants