-
Notifications
You must be signed in to change notification settings - Fork 11
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
compat-29: Drop broken string-pixel-width and window-pixel-width (Fix #8
) These functions seem to hangup from time to time on 28.2 (seagle0128/doom-modeline#601). By dropping the functions the hangup in doom-modeline is resolved, since doom-modeline contains a runtime check for string-pixel-width. The compatibility function implementations do not contain any loops, this means there is an underlying bug in `window-text-pixel-size' in 28.2 exposed by the compatibility function. Either the compatibility function must be written in a different form or we cannot provide them at all.
- Loading branch information
Showing
2 changed files
with
0 additions
and
61 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7c17c96
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should fix emacs-dashboard/emacs-dashboard#430 (comment) as well.
7c17c96
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes of course. Therefore I removed these functions again.