Skip to content

Commit

Permalink
Respect to widget-button face.
Browse files Browse the repository at this point in the history
  • Loading branch information
@jcs090218
jcs090218 committed Dec 7, 2020
1 parent dabb6bd commit d792141
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions dashboard-widgets.el
View file
Original file line number Diff line number Diff line change
Expand Up @@ -545,7 +545,7 @@ If MESSAGEBUF is not nil then MSG is also written in message buffer."
(when title (propertize title 'face face)))
:help-echo help
:action action
:button-face `(:underline nil)
:button-face 'widget-button
:mouse-face 'highlight
:button-prefix prefix
:button-suffix suffix
Expand Down Expand Up @@ -607,7 +607,7 @@ WIDGET-PARAMS are passed to the \"widget-create\" function."
(widget-create 'item
:tag tag
:action ,action
:button-face `(:underline nil)
:button-face 'widget-button
:mouse-face 'highlight
:button-prefix ""
:button-suffix ""
Expand Down

4 comments on commit d792141

@rudi
Copy link
Contributor

@rudi rudi commented on d792141 Dec 9, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, with this change, all lines are blue and underlined, including the icons. The icons are not colored anymore either, but are blue and underlined. I've reverted this in my local checkout for now since I like the previous look better.

@jcs090218
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, I don't know if I made the wrong commitment here. I saw the document and I think dashboard should respect to widget-button face? Or else I some how not able to customize it locally. 😕 I might missing something here.

@rudi
Copy link
Contributor

@rudi rudi commented on d792141 Dec 10, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for replying, I figured it out - without a theme, your change looks fine. I use the theme modus-operandi, and in that theme the face widget-button is blue and underlined.

I'll think about a patch that adds a new face that derives from widget-button.

@jcs090218
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll think about a patch that adds a new face that derives from widget-button.

Yeah, that's what I am thinking and probably reasonable? This is low priority, I might do it after few days! Feel free to open a PR to do this. I will accept it! Thanks! 😄

Please sign in to comment.