Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vimish bindings #139

Merged
merged 2 commits into from Jun 27, 2019
Merged

Vimish bindings #139

merged 2 commits into from Jun 27, 2019

Conversation

ema2159
Copy link
Contributor

@ema2159 ema2159 commented Jun 2, 2019 •
edited

Very simple enhancement, makes j and k move the cursor down and up like in Vim so Evil users feel more familiar. It creates merge conflicts for some absurd reason although it only adds two lines. Also I fixed the screenshot!

@JesusMtnez
Copy link
Contributor

@ema2159 It looks the conflict happens because screenshot.png wasn't replaced (as it should be), but only added. Try to recreate the branch from master and it should force you to replace screenshot.png.

@JesusMtnez JesusMtnez self-requested a review June 3, 2019 08:20
@ema2159
Copy link
Contributor Author

ema2159 commented Jun 3, 2019

I'll try to fix that soon!

@ema2159
Copy link
Contributor Author

ema2159 commented Jun 14, 2019

@JesusMtnez I'm not able to add the new screenshot correctly, could you help me with that?

@JesusMtnez
Copy link
Contributor

@ema2159 Let's not update the screenshot in this PR, just add the vimish bindings. I'll update the screenshot.png in another PR. Sounds good?

@ema2159
Added "Vimish" bindings to j and k and fixed the screenshot
af711b8 
Try to fix screenshot commit

Replace screenshot

Removed new screenshot
@ema2159
Copy link
Contributor Author

ema2159 commented Jun 18, 2019

@ema2159 Let's not update the screenshot in this PR, just add the vimish bindings. I'll update the screenshot.png in another PR. Sounds good?

Ok done!

@JesusMtnez
Copy link
Contributor

I'll prepare the screenshot tomorrow and I'll merge this PR too. Thank you @ema2159

@ema2159
Copy link
Contributor Author

ema2159 commented Jun 21, 2019

You're welcome Jesus. It as a pleasure to work with you. If you need something just let me know and I'll be glad to help!

@JesusMtnez JesusMtnez merged commit 94d1355 into emacs-dashboard:master Jun 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JesusMtnez JesusMtnez JesusMtnez approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ema2159 @JesusMtnez