Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove (require 'seq) #165

Merged
merged 1 commit into from Jul 1, 2019
Merged

Remove (require 'seq) #165

merged 1 commit into from Jul 1, 2019

Conversation

jcs090218
Copy link
Member

@jcs090218 jcs090218 commented Jun 28, 2019 •
edited

Is this something what you want? #161

@jcs090218 jcs090218 changed the title Try fixing issue 164. Try fixing issue 161. Jun 28, 2019
@JesusMtnez JesusMtnez self-requested a review June 28, 2019 15:03
@JesusMtnez JesusMtnez changed the title Try fixing issue 161. Remove (require 'seq) Jul 1, 2019
@JesusMtnez JesusMtnez merged commit 7063ea2 into emacs-dashboard:master Jul 1, 2019
@jcs090218 jcs090218 deleted the replace-seq-take branch July 1, 2019 07:37
@jcs090218
Copy link
Member Author

jcs090218 commented Jul 1, 2019 •
edited

@JesusMtnez Does this works for you? Cuz after I updated to this branch, it breaks again... Sorry for this PR. Not sure where are differences between seq-take and the code implemented...

jcs090218
jcs090218 commented Jul 1, 2019
View reviewed changes
Copy link
Member Author

@jcs090218 jcs090218 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small comment.

dashboard.el Show resolved Hide resolved
@JesusMtnez
Copy link
Contributor

@jcs090218 how does it break? I'm not having any problem 🤔

@jcs090218
Copy link
Member Author

@JesusMtnez Sorry for reporting this. I guess is just a versioning issue on my company's PC. :P My bad!

JesusMtnez added a commit that referenced this pull request Jul 2, 2019
@JesusMtnez
Revert "Remove (require 'seq) (#165)"
f9f1f5e 
This reverts commit 7063ea2.
@JesusMtnez
Copy link
Contributor

I had to revert the change, something was wrong when the emacs-dashboard was refreshed. 🤔

@jcs090218
Copy link
Member Author

I was confused, I guess is because I overwrite the dashbaord refresh function. Sorry about this PR. :(

@JesusMtnez
Copy link
Contributor

No worries @jcs090218 ! These things happen sometimes, even more often when there is not a test suite to check those changes. But I think this will help us with the next PR to completely remove (require 'seq) for sure 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JesusMtnez JesusMtnez JesusMtnez approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jcs090218 @JesusMtnez