Fix icons for weekly agenda and add an icon final condition #173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Will help people who want to run a custom dashboard section
|
My bad for the linting. I forgot to run the tests on my machine first. |
JesusMtnez
approved these changes
Jul 3, 2019
|
Thank you @DuCorey ! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a fix for #146.
I simply check for either the daily agenda or the weekly agenda string.
I've also taken the liberty of adding a final condition that will always return an empty string so that the heading creation cannot fail when it can't find an icon. This could be useful for people who want to make a custom heading and still some of the icons.