Disable display-line-numbers-mode #182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There are few problems with this PR.
|
|
It looks like now there's an issue with the final step that isn't due to this PR in particular. |
|
Yeah, I think you could just update the branch to the latest commit to resolve this kind of issue. Anyway, I am good with this kind of PR. Thanks! One last minor issue.
|
…-mode (hiding line numbers in the dashboard by default)
|
I have rebased on master and fixed spacing. I'm not sure why test-emacs-25 is failing; when a condition fails the following elisp isn't supposed to be evaluated, so Emacs 25 shouldn't even know that symbol is there. Is this not the case for |
|
@zjp I don't think the emacs --batch -q -l .emacs/init.el
Contacting host: elpa.gnu.org:80
Failed to download `melpa' archive.
Package `use-package-' is unavailable
Makefile:12: recipe for target '.elpa' failed
make: *** [.elpa] Error 255I think we could simply just rerun the test. @JesusMtnez What do you think? 😕 Thanks! |
JesusMtnez
approved these changes
Feb 25, 2020
JesusMtnez
changed the title
JesusMtnez
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a short
onetwo-liner commit to add support for hiding line numbers by default for users ofglobal-display-line-numbers-mode, the way they are hidden for users ofglobal-linum-mode. It checks the major version first, since the new mode was added in Emacs 26.