Refactor: use all-the-icons-icon-for-dir #198
Conversation
dashboard-widgets.el
Outdated
| (declare-function all-the-icons-fileicon "ext:all-the-icons.el") | ||
| (declare-function all-the-icons-octicon "ext:all-the-icons.el") |
There was a problem hiding this comment.
Since you replace all the logic with all-the-icons-icon-for-dir, are those necessary? They are not being used anywhere now 🤔
There was a problem hiding this comment.
No, all-the-icons-fileicon and all-the-icons-octicon are used in other functions.
There was a problem hiding this comment.
I see. I'm trying to debug why the linter is complaining 🤔 . So far, if those two lines are removed, it does not complain. But I don't see why it complains if they are being used later in the code 🤔 .
There was a problem hiding this comment.
I think I've found why it is failing. Those two functions are not really defined, they are generated using the macro define-icon. Code here
That is why the linter is not able to find the function declaration.
dashboard-widgets.el
Outdated
| @@ -20,10 +20,13 @@ | |||
|
|
|||
| ;;; Code: | |||
|
|
|||
| (require 'cl-lib) | |||
There was a problem hiding this comment.
Why adding this require ❓
There was a problem hiding this comment.
This is for addressing the compiling warnings (not defined: cl-subseq), and cl is deprecated in 27.
There was a problem hiding this comment.
I was not implying removing this line. I was just curious why (not using Emacs master version, still in Emacs 26.3). I think it would be great to add this change. Sorry I do not explain myself clear 😄
Thank you @seagle0128
|
BTW, whenever you can, please update this branch with current master content, since the linter has been updated. Thank you @seagle0128 |
|
@JesusMtnez Sure. I fixed the linting errors, but the compiling warnings will be there. Update: It seems the linting process is unable to start in CI. emacs --batch -q -l .emacs/init.el -l .emacs/elpa/elisp-lint-20180224.2042/elisp-lint.el -f elisp-lint-files-batch dashboard-widgets.el dashboard.el
Loading /root/project/.emacs/.emacs-custom.el (source)...
Loading /root/project/.emacs/dependencies.el (source)...
Cannot open load file: No such file or directory, .emacs/elpa/elisp-lint-20180224.2042/elisp-lint.el
Makefile:19: recipe for target 'lint' failed
make: *** [lint] Error 255 |
|
You need to sync this branch with current |
Update from master branch.
|
Okay. Already updated. |
|
Perfect! Now it is passing! If you want, restore |
|
@JesusMtnez It's fine to merge now. Thanks! |
JesusMtnez
changed the title
No description provided.