Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid loading all-the-icons prematurely #209

Merged
merged 2 commits into from Jan 20, 2020
Merged

Avoid loading all-the-icons prematurely #209

merged 2 commits into from Jan 20, 2020

Conversation

seagle0128
Copy link
Contributor

Check if all-the-icons is loaded before using it.

Fix seagle0128/.emacs.d#150.

@seagle0128 seagle0128 mentioned this pull request Jan 17, 2020
Closed
@JesusMtnez
Copy link
Contributor

@seagle0128 Nice catch! Merging it now!

@JesusMtnez JesusMtnez merged commit 55e6aae into emacs-dashboard:master Jan 20, 2020
@JesusMtnez JesusMtnez changed the title Fix project Avoid loading all-the-icons prematurely Jan 20, 2020
@seagle0128
Copy link
Contributor Author

Thanks!

There is still an issue in all-the-icons-icon-for-dir. Already filed an issue domtronn/all-the-icons.el#184.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JesusMtnez JesusMtnez JesusMtnez approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

在Windows下如果打开一个不是project的文件，将会出错
2 participants
@seagle0128 @JesusMtnez