Support for image transforms in newer Emacs #278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In `dashboard-insert-image-banner' check also for image transforms functionality to scale images to `:max-width' / `:max-height'
jcs090218
approved these changes
Dec 21, 2020
|
I have tested and it works! I wonder what does this patch does? Would it be necessary to check for transforming the image? Appreciate if you could elaborate it! Anyway, thanks for the contribution! 😄 |
JesusMtnez
approved these changes
Dec 21, 2020
Newer Emacs has image transformations functionality, so images could be scaled or rotated even if imagemagick is not compiled in (in newer Emacs imagemagick is disabled by default). This patch utilizes this image transforms functionality (if available) to scale Emacs logo |
|
Thanks for the elaboration! Merged! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
dashboard-insert-image-bannercheck also for image transformsfunctionality to scale images to
:max-width/:max-heigh