Agenda highlight headlines #281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for fixing this bug for us. I wonder maybe we can remove variable |
Introduces `dashboard-agenda-highlight-headlines` as a Boolean to highlight agenda headlines using org default faces. Headlines are highlighted by setting the corresponding `face` text-property to each part of the headline. Issue emacs-dashboard#264 shows that headlines are highlighted only after visit the org buffer and when org buffer is killed headlines looses their faces. I couldn't found the function that sets the faces, so now faces are assigned to the TODO and HEADING parts only if they don't already had a face.
ricardoricho
force-pushed
the
highlight
branch
from
0a6c8e9
to
a3b4cf1
Compare
jcs090218
approved these changes
Dec 29, 2020
|
LGTM, thanks for making this package better! ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces
dashboard-agenda-highlight-headlinesas a Boolean tohighlight agenda headlines using org default faces.
Headlines are highlighted by setting the corresponding
facetext-property to each part of the headline. Issue #264 showsthat headlines are highlighted only after visit the org buffer and
when org buffer is killed headlines looses their faces.
I couldn't found the function that sets the faces, so now
faces are assigned to the TODO and HEADING parts only if they don't
already had a face.