Allow section headings to be customized #316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Section headings can now be given custom names through `dashboard-item-names'. Since this is done through overlays it doesn't break any function that expects the headings to have their default names.
jcs090218
reviewed
Jul 17, 2021
Also fix the issue with `dashboard-center-content' by using the correct marker insertion type when making the overlay.
|
Can you fix the CI for us? And I forgot to mentioned, can you add document to our README file so the user would know this nice new feature? 😁 Thanks! |
|
Done :-) |
jcs090218
approved these changes
Jul 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #305
Section headings can now be given custom names through `dashboard-item-names'.
Since this is done through overlays it doesn't break any function that expects
the headings to have their default names.
It would arguably be more elegant to adapt all of the aforementioned cases to
use a system that can handle any name, but the work necessary would be a lot
more extensive than this, and I don't know how much of the codebase one would
want to revamp to accommodate this single feature.