Fix init-info reporting wrong `emacs-init-time' #330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch fixes an issue where the init info doesn't show the correct value of `emacs-init-time`. The cause is due the `defcustom` default value being computed at whatever time this package is loaded, which not necessarily represent the final startup time. As example, on my local use-package based setup it reports something around 0.6 seconds, while manually calling `M-x emacs-init-time` does say 2.5 seconds. The fix is wrapping the default message inside a lambda, to defer computing until render time. This change should keep old behaviour, in case any user override `dashboard-init-info` with some fixed string.
jcs090218
approved these changes
Sep 28, 2021
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch fixes an issue where the init info doesn't show the correct value of
emacs-init-time.The cause is due the
defcustomdefault value being computed at whatever time this package is loaded, which not necessarily represent the final startup time. As example, on my local use-package based setup it reports something around 0.6 seconds, while manually callingM-x emacs-init-timedoes say 2.5 seconds.The fix is wrapping the default message inside a lambda, to defer computing until render time. This change should keep old behavior, in case any user override
dashboard-init-infowith some fixed string.