Make icon display predicate customizeable #442
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcs090218
reviewed
Mar 11, 2023
| :type '(choice (function :tag "Predicate function") | ||
| (boolean :tag "Predicate value"))) | ||
|
|
||
| (defun dashboard-display-icons-p () |
There was a problem hiding this comment.
Can you document this function? Thanks!
There was a problem hiding this comment.
Sure, just added a simple docstring.
jcs090218
reviewed
Mar 12, 2023
dashboard-widgets.el
Outdated
| to a function the result of the function will be interpreted as the | ||
| predicate value." | ||
| :type '(choice (function :tag "Predicate function") | ||
| (boolean :tag "Predicate value"))) |
There was a problem hiding this comment.
We're getting warning:
dashboard-widgets.el:198:1:Warning: defcustom for ‘dashboard-display-icons-p’
fails to specify containing group
dashboard-widgets.el:198:1:Warning: defcustom for ‘dashboard-display-icons-p’
fails to specify containing group
Can you add the group for it? :)
jcs090218
approved these changes
Mar 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #333.
Adds a customizeable function to restrict icon insertion and default it to display-graphic-p to retain legacy behavior. This will let terminal users who have icons properly configured use dashboard with icons without needing local modifications.