Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change default of ess-eval-visibly? #998

Closed
jabranham opened this issue Mar 15, 2020 · 9 comments · Fixed by #1014
Closed

Change default of ess-eval-visibly? #998

jabranham opened this issue Mar 15, 2020 · 9 comments · Fixed by #1014

Comments

@jabranham
Copy link
Contributor

What do people think about changing the default of ess-eval-visibly? I think the current default, which blocks Emacs, comes as a surprise to a lot of people, especially newcomers. IME it's one of the first things people change or they get frustrated by.

I'd probably chose nil over nowait since our output isn't perfect.

@lionel-
Copy link
Member

lionel- commented Mar 16, 2020

I agree with your analysis.

@vspinu
Copy link
Member

vspinu commented Mar 17, 2020

Agreed. Other emacs interactive environments do similar stuff as our nil setting.

@jabranham
Copy link
Contributor Author

Done in 625041a

@lionel-
Copy link
Member

lionel- commented May 3, 2020

I have just tried nil visibility and I find the output confusing. It's difficult to distinguish boundaries between evaluation batches. Also there's nothing to remind the user what expressions produced the output. What do you think about switching to 'nowait? I expect this setting to be a better compromise for most users.

@lionel- lionel- reopened this May 3, 2020
@jabranham
Copy link
Contributor Author

jabranham commented May 3, 2020 via email

@lionel-
Copy link
Member

lionel- commented May 3, 2020

What are the cons of nowait?

@jabranham
Copy link
Contributor Author

jabranham commented May 3, 2020 via email

@gdkrmr
Copy link

gdkrmr commented May 3, 2020

+1 for 'nowait

@vspinu
Copy link
Member

vspinu commented May 4, 2020

Nowait with regions will not result in inter-woven input-output as people might expect. But, indeed, it results in better delineation of execution chunks, and that's good enough.

I personally prefer nil to nowait as I almost never scrol up, and when I do, I usually know what kind of output I look for. + less garbage etc.

I am quite indifferent, we can go with 'nowait if majority so desire.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants