Skip to content

Commit

Permalink
Add version to `define-obsolete-function-alias' invocation
Browse files Browse the repository at this point in the history 
The latest Emacs 28 requires this.
  • Loading branch information
@leungbk @TheBB
leungbk authored and TheBB committed Jan 9, 2021
1 parent d6cf668 commit 19cc5f8
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion evil-ex.el
View file
Original file line number Diff line number Diff line change
Expand Up @@ -595,7 +595,7 @@ argument handler that requires shell completion."

(define-obsolete-function-alias
'evil-ex-shell-command-completion-at-point
'comint-completion-at-point)
'comint-completion-at-point "1.2.13")

(evil-ex-define-argument-type shell
"Shell argument type, supports completion."
Expand Down

3 comments on commit 19cc5f8

@phikal
Copy link

@phikal phikal commented on 19cc5f8 Apr 12, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The current version on NonGNU ELPA appears to not have this change included. Trying to enable evil mode without this lands the user in a partial state that is neither emulating Vim nor has all the Emacs bindings anymore.

@shivahnshankar
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tripped on this as well. Using Rational Emacs.
Here is some helpful tips to work around in the meantime.
SystemCrafters/crafted-emacs#126
However, its best if the current version can be pushed

@phikal
Copy link

@phikal phikal commented on 19cc5f8 Apr 15, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems like it would make more sense to bring this up in #1523 than here. I don't know if the maintainers are notified about comments on commits.

Please sign in to comment.