Declare goto-char as a motion, fix evil-goto-char

Tests added for evil-goto-char. Fixes #1852
emacs-evil · Dec 25, 2023 · 2bd0cea · 2bd0cea
1 parent fc6bd00
commit 2bd0cea
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 2 deletions.
diff --git a/evil-commands.el b/evil-commands.el
@@ -4270,7 +4270,7 @@ range. The given argument is passed straight to
         (evil-force-normal-state)
         (set-marker marker nil)))))
 
-(evil-define-command evil-goto-char (position)
+(evil-define-motion evil-goto-char (position)
   "Go to POSITION in the buffer.
 Default position is the beginning of the buffer."
   :jump t

diff --git a/evil-tests.el b/evil-tests.el
@@ -3704,7 +3704,9 @@ Below some empty line"))
    ("go")
    "[W]e only need a short buffer for this test"
    (evil-goto-char 24)
-   "We only need a short bu[f]fer for this test"))
+   "We only need a short bu[f]fer for this test"
+   ("v29go")
+   "We only need a short bu<ffer [f]>or this test"))
 
 (ert-deftest evil-test-operator-0 ()
   "Test motion \"0\" with an operator."

diff --git a/evil-vars.el b/evil-vars.el
@@ -1030,6 +1030,7 @@ intercepted."
     forward-sentence
     forward-sexp
     forward-word
+    goto-char
     goto-last-change
     ibuffer-backward-line
     ibuffer-forward-line