Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backreferences in search fail to work with vim-style-regexp #1895

Closed
totallyuniquelily opened this issue Apr 29, 2024 · 2 comments · Fixed by #1897
Closed

Backreferences in search fail to work with vim-style-regexp #1895

totallyuniquelily opened this issue Apr 29, 2024 · 2 comments · Fixed by #1897

Comments

@totallyuniquelily
Copy link

totallyuniquelily commented Apr 29, 2024

Issue type

  • Bug report

Environment

Emacs version: GNU Emacs 29.3 (build 2, x86_64-unknown-linux-gnu, GTK+ Version 3.24.41, cairo version 1.18.0) of 2024-03-25
Operating System: Void Linux
Evil version: Evil version 1.15.0 (reproduced with github master as well)
Evil installation type: Doom (which I think uses ELPA)
Graphical/Terminal: Graphical
Tested in a make emacs session (see CONTRIBUTING.md): Yes

Reproduction steps

  • Start Emacs (with make emacs)
  • open a scratch buffer and insert text with repeating letters (e.g. "green wood")
  • enable evil-search search module (M-: (evil-select-search-module 'evil-search-module 'evil-search))
  • enable vim-style regexp (M-: (setq evil-ex-search-vim-style-regexp t))
  • type /\(.\)\1 (or /\v(.)\1)

Expected behavior

search would find "ee" and "oo"

Actual behavior

search fails

Further notes

\(.\)\1 works the same in (neo)vim and isearch. just not in evil-search with evil-ex-search-vim-style-regexp enabled. (and works if that variable is set to nil)

@tomdl89
Copy link
Member

tomdl89 commented Apr 30, 2024

Thanks @totallyuniquelily I can reproduce this. Will take a look when I get some time.

tomdl89 added a commit to tomdl89/evil that referenced this issue May 6, 2024
tomdl89 added a commit that referenced this issue May 6, 2024
@tomdl89
Copy link
Member

tomdl89 commented May 6, 2024

@totallyuniquelily this should now be fixed in master. Let me know if you observe otherwise.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants