-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate XEmacs support and XEmacs toolbar #59
Conversation
I think we need to prepare some regression tests first and then, remove something. |
I fixed CI on #60 (but CI on Emacs-25.* is failed because some of Cask issue). Please rebase HEAD? Currently, our test-file is very poor, but we can check gnuplot.el could be load and byte-compile. |
Rebased and ran tests. Everything is looking good except the deprecation warning for cl and flet, which I intend to fix in a separate commit. Improving the test suite will be indeed necessary at some point. @conao3 do the changes look OK for you? |
I think you should not bump the version number in this commit. It cannot hurt to have this only be used by
😜 |
Yes that makes much more sense indeed. My plan was to do a release-specific commit (and move the changelog found in gnuplot.el to a dedicated CHANGELOG file). But wouldn't have waited a few days for the release, which could have been bad since this commit is not trivial and could break things for users. Sorry, this is the first package I am maintaining 😬 I renamed the commit message accordingly. |
We may remove other (
|
I am not going to change the documentation and Makefiles just yet, but I am going to remove what remains in gnuplot and gnuplot-context.el. Note that most of the matches in gnuplot.el are from the changelog at the beginning of the file, and those should be kept (I am going to create a CHANGELOG file though). |
Remove all functions and checks relative to XEmacs, include the gnuplot-mode toolbar and associated bitmaps. Mark deprecated modules and functions for future fixes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
Sorry, ignore me. |
This is my first attempt at removing support for XEmacs in gnuplot-mode.
These changes are NOT tested, because I haven't yet found a simple way to locally test my changes (I am only getting started in Emacs packages development). However I did not use any functionality to the package, just removed all occurrences of XEmacs, making sure to replace any obsolete functions and variables caused by these changes. I used flycheck and package-lint on the resulting files.
The original commit message is below:
Remove all functions and checks relative to XEmacs, including the
gnuplot-mode toolbar and associated bitmaps.
Mark deprecated modules and functions for future fixes.