Code actions do nothing

[haselwarter]

I installed eglot-grammarly via straight, on GNU Emacs 30.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.24.38, cairo version 1.17.8) of 2023-08-04 (i.e. recent git HEAD).
Code actions don't seem to do anything. They are suggested, and I can select one, but nothing happens then. With lsp-grammarly it works fine.

[jcs090218]

There is an LSP-compatible issue between eglot and grammarly-lagnauge-server; therefore, that's why it isn't working. I suggest people use lsp-grammarly. Otherwise, there isn't much I can do.

[haselwarter]

Oh that's unfortunate. Is this an eglot bug?

[jcs090218]

Oh that's unfortunate. Is this an eglot bug?

It's eglot unwilling to officially support grammarly-language-server since I can easily do it with lsp-mode but not with eglot. 🤔

[haselwarter]

Sorry, I'm not sure I follow. Code actions in general are supported by Eglot. Is there a bug report on the Eglot issue tracker (https://github.com/joaotavora/eglot/issues) ?

[jcs090218]

The language-server does support workspace/executeCommand. I have checked eglot's source code, and it does have it defined https://github.com/joaotavora/eglot/blob/8b5532dd32b25276c1857508030b207f765ef9b6/eglot.el#L2181-L2186. 🤔

Reference for myself: znck/grammarly#277

[jcs090218]

Oh, just realized this issue is duplicate to #7. It should be fixed in the latest eglot version!