Fix 404 error when attempting to download OpenVSX extensions #762
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change fixes this error when running `(dap-node-setup)`: `url-insert-file-contents: https://open-vsx.org/api/ms-vscode/node-debug2/latest/: Not found` The problem was that the OpenVSX URL template string had a trailing slash, which is not handled by OpenVSX's Registry API Controller: https://github.com/eclipse/openvsx/blob/master/server/src/main/java/org/eclipse/openvsx/RegistryAPI.java#L348 I can't really find a blame in the OpenVSX repo which could've caused the extraneous trailing slash. Maybe the update to Java 17? As you can see, there's no trailing slash at the end, so the route doesn't get mached in the controller and causes a 404 Not Found. Just removing the slash does the job and `(dap-node-setup)` runs successfully. References: - #554 (comment) - #700
|
Until the PR is merged you can just set the value of the custom variable in your local emacs config - |
yyoncho
approved these changes
Nov 10, 2023
|
Thank you for contributing to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change fixes this error when running
(dap-node-setup):url-insert-file-contents: https://open-vsx.org/api/ms-vscode/node-debug2/latest/: Not foundThe problem was that the OpenVSX URL template string had a trailing slash, which is not handled by OpenVSX's Registry API Controller: https://github.com/eclipse/openvsx/blob/master/server/src/main/java/org/eclipse/openvsx/RegistryAPI.java#L348
I can't really find a blame in the OpenVSX repo which could've caused the extraneous trailing slash to stop working. Maybe the update to Java 17?
As you can see, there's no trailing slash at the end, so the route doesn't get mached in the controller and causes a 404 Not Found.
Just removing the slash does the job and
(dap-node-setup)runs successfully.References:
You can also try it yourself: