Read container-name from lsp-docker.yml both for image and container … #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@korenhe , sorry for the late reply! What about not reading names for images (containers created from them are meant to be only temporary, this is the whole point of using this server type) but randomizing them? As far as I remember there was a function used for adding random suffixes to container names. Maybe integrate it somehow? As for the container names we can just use random strings (as I wrote above the containers are temporary and are deleted when the server stops). |
For image type, the container-name is nil and makes the name of repeated creation of container conflicts with each other. This patch provides a default name "lsp-container" with an increamental suffix to let multiple containers run at the same time, the 'docker ps' output is like this: CONTAINER ID IMAGE ... NAMES 33501e5e3305 testimage:latest ... lsp-container-2 e9808f58a29f testimage:latest ... lsp-container-1
|
Closing this PR as the underlying issue is now fixed by another PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…type
For image type, the container-name is nil and makes the name of repeated
creation of container conflicts with each other.