Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error wrong-type-argument symbolp "generate" occurs when using gopls #1778

Closed
yuezhu opened this issue Jun 10, 2020 · 6 comments
Closed

Error wrong-type-argument symbolp "generate" occurs when using gopls #1778

yuezhu opened this issue Jun 10, 2020 · 6 comments
Labels
go

Comments

@yuezhu
Copy link

yuezhu commented Jun 10, 2020 •
edited

Describe the bug
When opening a go file with gopls enabled, below error will occur:

Error processing message (wrong-type-argument symbolp "generate").

This error has started seeing since today's lsp-mode update.

To Reproduce
I have below configuration for lsp-mode:

(use-package lsp-mode
  :ensure t
  :hook
  ((go-mode python-mode) . lsp-deferred)
  (lsp-mode . lsp-enable-which-key-integration)

  :defer t

  :config
  (require 'lsp-clients)
  (require 'lsp-go)
  (require 'lsp-pyls)

  (lsp-register-custom-settings
   '(("gopls.completeUnimported" t t)
     ("gopls.staticcheck" t t))))
  1. Make sure corresponding GOPATH is set correctly.
  2. Right after opening a go file, the error will pop up.

Expected behavior
The error should not occur.

Which Language Server did you use

GNU Emacs 27.0.91 (build 1, x86_64-apple-darwin19.5.0, NS appkit-1894.50 Version 10.15.5 (Build 19F101)) of 2020-06-09

Using lsp-mode 20200610.1720

$ gopls version
golang.org/x/tools/gopls 0.4.1
    golang.org/x/tools/gopls@v0.4.1 h1:0e3BPxGV4B3cd0zdMuccwW72SgmHp92lAjOyxX/ScAw=

OS
Mac OS 10.15.5 (19F101)

Error callstack

Debugger entered--Lisp error: (wrong-type-argument symbolp "generate")
  json-serialize((:jsonrpc "2.0" :id 2 :result [#<hash-table equal 6/65 0x1fff871a968d> nil]) :null-object nil :false-object :json-false)
  lsp--make-message((:jsonrpc "2.0" :id 2 :result [#<hash-table equal 6/65 0x1fff871a968d> nil]))
  lsp--send-request-response(#s(lsp--workspace :ewoc nil :server-capabilities #<hash-table equal 20/20 0x1fff88e0e9cd> :registered-server-capabilities (#s(lsp--registered-capability :id "workspace/didChangeWatchedFiles" :method "workspace/didChangeWatchedFiles" :options #<hash-table equal 1/1 0x1fff87452329>)) :root "/Users/yuezhu/work/gocode" :client #s(lsp--client :language-id nil :add-on? nil :new-connection (:connect #f(compiled-function (filter sentinel name environment-fn) #<bytecode 0x1fff8731fd51>) :test\? #f(compiled-function () #<bytecode 0x1fff8731fd65>)) :ignore-regexps nil :ignore-messages nil :notification-handlers #<hash-table equal 0/65 0x1fff8731fd71> :request-handlers #<hash-table equal 0/65 0x1fff87320049> :response-handlers #<hash-table eql 0/65 0x1fff87320339> :prefix-function nil :uri-handlers #<hash-table equal 0/65 0x1fff87320631> :action-handlers #<hash-table equal 0/65 0x1fff87320929> :major-modes (go-mode go-dot-mod-mode) :activation-fn nil :priority 0 :server-id gopls :multi-root nil :initialization-options nil :custom-capabilities nil :library-folders-fn lsp-clients-go--library-default-directories :before-file-open-fn nil :initialized-fn nil :remote? nil :completion-in-comments? nil :path->uri-fn nil :uri->path-fn nil :environment-fn nil :after-open-fn nil :async-request-handlers #<hash-table equal 0/65 0x1fff87320c01> :download-server-fn nil :download-in-progress? nil :buffers nil) :host-root nil :proc #<process gopls> :cmd-proc #<process gopls> :buffers (#<buffer main.go>) :semantic-highlighting-faces nil :semantic-highlighting-modifier-faces nil :extra-client-capabilities nil :status initialized :metadata #<hash-table equal 0/65 0x1fff88e734c9> :watches #<hash-table equal 0/65 0x1fff88e736f9> :workspace-folders nil :last-id 0 :status-string nil :shutdown-action nil :diagnostics #<hash-table equal 0/65 0x1fff88e73719> :work-done-tokens #<hash-table equal 0/65 0x1fff88e73739>) (24289 9814 122397 0) #<hash-table equal 4/4 0x1fff89d1d6b9> [#<hash-table equal 6/65 0x1fff871a968d> nil])
  lsp--on-request(#s(lsp--workspace :ewoc nil :server-capabilities #<hash-table equal 20/20 0x1fff88e0e9cd> :registered-server-capabilities (#s(lsp--registered-capability :id "workspace/didChangeWatchedFiles" :method "workspace/didChangeWatchedFiles" :options #<hash-table equal 1/1 0x1fff87452329>)) :root "/Users/yuezhu/work/gocode" :client #s(lsp--client :language-id nil :add-on? nil :new-connection (:connect #f(compiled-function (filter sentinel name environment-fn) #<bytecode 0x1fff8731fd51>) :test\? #f(compiled-function () #<bytecode 0x1fff8731fd65>)) :ignore-regexps nil :ignore-messages nil :notification-handlers #<hash-table equal 0/65 0x1fff8731fd71> :request-handlers #<hash-table equal 0/65 0x1fff87320049> :response-handlers #<hash-table eql 0/65 0x1fff87320339> :prefix-function nil :uri-handlers #<hash-table equal 0/65 0x1fff87320631> :action-handlers #<hash-table equal 0/65 0x1fff87320929> :major-modes (go-mode go-dot-mod-mode) :activation-fn nil :priority 0 :server-id gopls :multi-root nil :initialization-options nil :custom-capabilities nil :library-folders-fn lsp-clients-go--library-default-directories :before-file-open-fn nil :initialized-fn nil :remote? nil :completion-in-comments? nil :path->uri-fn nil :uri->path-fn nil :environment-fn nil :after-open-fn nil :async-request-handlers #<hash-table equal 0/65 0x1fff87320c01> :download-server-fn nil :download-in-progress? nil :buffers nil) :host-root nil :proc #<process gopls> :cmd-proc #<process gopls> :buffers (#<buffer main.go>) :semantic-highlighting-faces nil :semantic-highlighting-modifier-faces nil :extra-client-capabilities nil :status initialized :metadata #<hash-table equal 0/65 0x1fff88e734c9> :watches #<hash-table equal 0/65 0x1fff88e736f9> :workspace-folders nil :last-id 0 :status-string nil :shutdown-action nil :diagnostics #<hash-table equal 0/65 0x1fff88e73719> :work-done-tokens #<hash-table equal 0/65 0x1fff88e73739>) #<hash-table equal 4/4 0x1fff89d1d6b9>)
  lsp--parser-on-message(#<hash-table equal 4/4 0x1fff89d1d6b9> #s(lsp--workspace :ewoc nil :server-capabilities #<hash-table equal 20/20 0x1fff88e0e9cd> :registered-server-capabilities (#s(lsp--registered-capability :id "workspace/didChangeWatchedFiles" :method "workspace/didChangeWatchedFiles" :options #<hash-table equal 1/1 0x1fff87452329>)) :root "/Users/yuezhu/work/gocode" :client #s(lsp--client :language-id nil :add-on? nil :new-connection (:connect #f(compiled-function (filter sentinel name environment-fn) #<bytecode 0x1fff8731fd51>) :test\? #f(compiled-function () #<bytecode 0x1fff8731fd65>)) :ignore-regexps nil :ignore-messages nil :notification-handlers #<hash-table equal 0/65 0x1fff8731fd71> :request-handlers #<hash-table equal 0/65 0x1fff87320049> :response-handlers #<hash-table eql 0/65 0x1fff87320339> :prefix-function nil :uri-handlers #<hash-table equal 0/65 0x1fff87320631> :action-handlers #<hash-table equal 0/65 0x1fff87320929> :major-modes (go-mode go-dot-mod-mode) :activation-fn nil :priority 0 :server-id gopls :multi-root nil :initialization-options nil :custom-capabilities nil :library-folders-fn lsp-clients-go--library-default-directories :before-file-open-fn nil :initialized-fn nil :remote? nil :completion-in-comments? nil :path->uri-fn nil :uri->path-fn nil :environment-fn nil :after-open-fn nil :async-request-handlers #<hash-table equal 0/65 0x1fff87320c01> :download-server-fn nil :download-in-progress? nil :buffers nil) :host-root nil :proc #<process gopls> :cmd-proc #<process gopls> :buffers (#<buffer main.go>) :semantic-highlighting-faces nil :semantic-highlighting-modifier-faces nil :extra-client-capabilities nil :status initialized :metadata #<hash-table equal 0/65 0x1fff88e734c9> :watches #<hash-table equal 0/65 0x1fff88e736f9> :workspace-folders nil :last-id 0 :status-string nil :shutdown-action nil :diagnostics #<hash-table equal 0/65 0x1fff88e73719> :work-done-tokens #<hash-table equal 0/65 0x1fff88e73739>))
  #f(compiled-function (proc input) #<bytecode 0x1fff88e6cdf1>)(#<process gopls> "Content-Length: 219\15\n\15\n{\"jsonrpc\":\"2.0\",\"method\":\"...")
@yuezhu yuezhu changed the title Errors occur when using gopls Error wrong-type-argument symbolp "generate" occurs when using gopls Jun 10, 2020
@yuezhu
Copy link
Author

yuezhu commented Jun 10, 2020

After looking at cceafa0, I have set lsp-gopls-codelens to nil to avoid hitting the error.

@yyoncho
Copy link
Member

yyoncho commented Jun 10, 2020

@ibizaman willing to take a look? I think that the keys has to be symbols/keywords for emacs 27 native serialization.

@yyoncho yyoncho added the go label Jun 10, 2020
@ibizaman
Copy link
Contributor

Sorry about that @yuezhu, I’ll take a look this evening @yyoncho

@yyoncho
Copy link
Member

yyoncho commented Jun 14, 2020

@ibizaman any update on that?

@poppyschmo
Copy link

Been encountering this, too.

I think that the keys has to be symbols/keywords for emacs 27 native serialization

For alists, that appears to be the case, which is inconvenient, but there's probably a reason. Original patch and thread from 2017.

@ibizaman
Copy link
Contributor

ibizaman commented Jun 15, 2020 •
edited

@yyoncho sorry while fixing this I dug deep into the rabbit hole of trying to reproduce the issue using automated tests. I’ll instead switch to just fix it with manual tests.

@ibizaman ibizaman mentioned this issue Jun 15, 2020
Closed
@chayward1 chayward1 mentioned this issue Jun 17, 2020
Closed
thomasf added a commit to thomasf/dotfiles-thomasf-emacs that referenced this issue Jun 20, 2020
@thomasf
lsp: fix gopls not working
7fe3c7d 
emacs-lsp/lsp-mode#1778
cesarbp added a commit to cesarbp/.emacs.d that referenced this issue Aug 18, 2020
@cesarbp
Squashed 'pkg/lsp-mode/' changes from 540eb3a38..b9b0f349c
fb29ef5 
b9b0f349c remove lsp-clients.el and its references (#2084)
7f971b1a1 add lsp-clangd.el (#2083)
cf31ca401 [lsp-lua] fix invalid executable testing for emmy-lua client (#2094)
7904b8387 Add lsp-ocaml.el (#2077)
99925f049 JavaScript and TypeScript clients to lsp-javascript.el (#2052)
50746a8e2 Add lsp-tex.el (#2073)
64d831e07 Add more commits to .git-blame-ignore-revs (#2091)
2feceabfe Add lsp-purescript.el (#2071)
bb9e9e629 Fix `lsp--document-highlight' (#2090)
00155a3e4 Add lsp-elixir.el (#2070)
de1571a3a Add lsp-hack.el (#2069)
1d11da05a Add lsp-fortran.el (#2068)
147079545 Lsp kotlin.el (#2063)
61528edba Lsp groovy.el (#2062)
619d1c572 PHP clients to lsp-php.el (#2058)
4f2a02101 [docs] fix installation-url spacing
fbf5d171e Nim clients to lsp-nim.el (#2057)
0b37a7a75 fixup! Allow querying for highlights when point is on an active highlight. (#2089)
0a4668b00 Allow querying for highlights when point is on an active highlight. (#1647)
91656fa90 VimScript client to lsp-vimscript.el (#2055)
f9e2f51c2 fixup! [infra] Add indentation commit to .git-blame-ignore-revs (#2087)
50c0564eb [docs] Fix when server has installation and installation-url
027421fd6 Angular client to lsp-angular.el (#2054)
4468d4f55 [infra] Add indentation commit to .git-blame-ignore-revs
48e53d1f4 Reindent `lsp-mode' using new indentation function
9b21b6798 [infra] Use Emacs 28's redefined `calculate-lisp-indent' as a wrapper
1d900ff5b Filter textDocument/didChangeWatchedFiles events according to kind (#2085)
70551a71b before-change-functions must save match data. (#2082)
cf7392b96 Add lsp-cmake.el (#2078)
9ba7bfc62 add lsp-rf.el (#2079)
cc6e5eef5 Declare project-root functions, and ignore warnings (#2043)
642e38223 Add custom document for lsp-pyright. (#2074)
bfa5f0b17 R clients to lsp-r.el (#2064)
2832879a2 lsp-clients--clangd-command: fix path so Windows also work in default conf (#2072)
bf6cceb70 Dhall clients to lsp-dhall.el (#2066)
720ec4f33 Ada client to lsp-ada.el file (#2050)
ece8e4d6b Bash client to lsp-bash.el (#2051)
a5dcd7c1e Use buffer-file-name function instead of buffer-file-name variable (#2047)
945846d80 Search for clangd executable in the path with names variations. (#2038)
79f147418 lsp-completion: change internal items format so info will not be dropped (#2059)
746643c2f Crystal clients to lsp-crystal.el (#2056)
598ec3976 Better cleanup on shutdown/restart (#2045)
f6317d74c Dockerfile client to lsp-dockerfile.el (#2053)
82695f9db Avoid using executable-find for binary defaults
a2896d5b3 Port VSCode's glob-to-regexp conversion (#2025)
c4daa529a change lsp-lens--refresh to lsp-lens-refresh (#2041)
0262e43fc Add Lua Language Server, Lua-Lsp and update EmmyLua (#2028)
dc09fe0b9 [docs] Add file watcher to performance section (#2034)
9ef743c1e Add Svelte support (#2035)
efe4847e9 Filter symbols by kind before being used to create imenu index (#2013)
8b7cc8347 Fix company-backends validation on lsp-diagnose and safe rename to lsp-doctor (#2023)
e70a3df6b Create lookups for all enums (#2014)
e89da11ae Support nested paths for workspace/configuration (#2015)
e726aabed Faces for rust-analyzer inlay hints (#2005)
175a43fb6 Fix lsp-go-build-flags variable #2020 (#2021)
248da66dc Remove go-langserver and bingo support, as they're deprecated. (#1422)
7c40b8c94 [diagnostics] Require flycheck (#2019)
875f99fe1 Fix quotation (#2017)
0a8313a38 Use widget for lsp-string-vector (#2012)
d31f591fd Dedup workspace folders upon initialize (#2016)
a8848b0e8 Custom modeline code actions (#1997)
2c8b57b2e Rework signature (#1998)
67e75a490 lsp--apply-text-edit: should filter CR before insert (#2011)
4db1151db Bump version
ef50aa7b0 Fix lsp-disabled-clients type mismatch (#2007)
edb81194f [infra] Add a .git-blame-ignore-revs file (#2006)
538c29fe9 Make sure that image is not nil before accessing it
28fae9122 Add missing autoloads for deprecated variables (#2001)
03509096d Prepare lsp-mode for :company-candidate-kind (#1995)
01bbdd9cd Move Flycheck/Flymake to lsp-diagnostics.el (#1990)
8e0f3f945 Fix IO tests for emacs 27+
44206860b Add links to cool projects
c333e4900 expand-snippet: indent according to the line where snippet is expanded (#1939)
a7532c3e9 Fix lsp-lens-backends variable (#1994)
b1d156094 Add a few ‘eval-and-compile’ forms. (#1992)
c7199f6bd Migrate to new form of ‘if-let’ and ‘when-let’. (#1991)
8fefce786 [performance] Improve some performance on headerline and modeline (#1988)
31e307e89 lsp-completion: move the rest of completion related code and change provider configure to align with diagnostic (#1984)
d42964113 lsp-perl: add customs for Perl::LanguageServer (#1986)
5b41a8df9 Add missing declare statements
4f2c143a5 Add dap-mode to right click menu
e80282163 Drop company-lsp support (#1983)
c81247c33 [docs] update modeline diagnostics main features
e059d1caa Update changelog with completion stuff (#1980)
21f710966 Run configure hook even if lsp-auto-configure is off
eda7bcd59 Introduce :none value for lsp-completion-provider
1caee9282 [migration] Move completion to file (#1967)
a2c3fa3df Update FAQ
0131f1f4c Expose the library folders for solargraph (#1974)
8ace94a71 Improve lens handling (#1963)
28f7dd2e7 Fix defcustom version and remove macro invocation in lsp-eslint (#1977)
de4d783d7 lsp--on-type-formatting: change back to using tick (#1975)
4444fcc88 lsp-command-map: check lsp-lens-mode bound before use (#1972)
5e0707849 [lsp-eslint] Handle source.fixAll.eslint code action (#1966)
417153e3f lsp--on-type-formatting: using lsp-merge instead of append (#1970)
798b22859 [docs] Use another Disqus account
def6e14a6 [docs] fix Disqus integration
1530757b9 Fix another typo (#1965)
1c18d4362 Fix typos (#1964)
f60a05485 Proposed fix for #1941
c0981074c Fixed the test for lsp--get-indent-width
92f0fe24f Added test for lsp--make-document-formatting-params
fdbc03c50 Fix lsp--get-indent-width
b08232485 Remove some Emacs < 26, and fix some whitespace/indentation (#1955)
87585f4df [blog] Add disqus comment support
82862cb6c formatting-params: using indent as tabsize (#1960)
aa52c6dc6 Generate unique name for code actions (#1958)
41ba94179 type-formatting: do best effort async text edits applying (#1959)
a352fc4c3 Add ert-profile to .gitignore
602934e54 Drop 25.x support (#1954)
1692d9f31 Merge completion results so :isIncomplete is preserved (#1937)
a94f6f861 [lens] Move lens to another file (#1953)
0a2786067 Make semantic tokens fetching conform to spec (#1906)
f04d0182f [modeline] move modeline features to separated file (#1931)
a7d87580b Handle when parent dirs are not present when doing rename/create (#1951)
15082f7a8 Fix the type of lsp-vetur-experimental-template-interpolation-service
0c3fff596 Improve the defcustom generator
dbf9bade9 lsp-headerline: go back to returning strings in the components (#1946)
e05e3844d Fix modeline face (#1945)
943c15e23 lsp-headerline: refactor and allow browsing clicked directories in Dired upon clicking (#1943)
388a7e88d completion: support resolveAdditionalTextEditsSupport capability (#1859)
0d200ec10 Move lsp-with-current-buffer declaration up
fa39a7864 Prefer rust analyzer
00fcee92a Indent snippets everywhere but in org-mode buffers (#1935)
8ae88c4b2 lsp-headerline--go-to-symbol: widen to include already narrowed region (#1938)
7206d36f5 Fix bug in `lsp-headerline--filename-with-icon` (#1934)
3f749aff6 Fix quote in lsp-rust code
52d5c9416 Do not call on-idle hooks on each server event
a3b6ed59c Fix the check for snippet text edit
124505afe Call lsp-unconfig-buffer and lsp-configure-buffer only in live buffers
9eb332486 [Rust-Analyzer] Support SnippetTextEdit (#1926)
fa7ca1f88 Replace .editorconfig with .dir-locals and .gitattributes (#1928)
305794f9d Wrap treemacs get icon call (#1919)
6b6e60535 Provide lsp-diagnostic-clean-after-change setting (#1927)
67b739cd9 [breadcrumb] Move headerline to another file (#1914)
0a2993eca Change danielmartin to kiennq in members list
70cfbdd63 readme: Add myself to member list (#1925)
872084574 use :is-incomplete in lsp-make-completion-list (#1923)
9571998e1 Prefer lsp-headerline-breadcrumb-symbols-face over -separator-face... (#1920)
e8ed95f0d Create CONTRIBUTING.md (#1908)
9921f58bf [breadcrumb] Permit visiting out-of-bounds parent symbols within a narrowed buffer (#1916)
865ab8bfe [breadcrumb] fix wrong font face
490dd3d49 Optionally number breadcrumb entries (#1915)
cf2cdf7cd Rename lsp-foo-bar-mode to lsp-placeholder-mode
5f7246307 Do not enable lsp checker for python-mode unconditionally
68cb3b2db [WIP] Permit dynamic semanticTokens registration (#1869)
3eac76ae9 breadcrumb cache path-up-to-project segment (#1913)
161bb549d for breadcrumb related cleanup (#1912)
56427e052 breadcrumb: handle files in project root (#1910)
bf241ddde plists migration - use lsp-signature-help?
bd0664027 [docs] add main features section with more features examples
a37aa7573 [breadcrumb] Fix unknown projects (#1909)
ce4d73558 Fix and improve rust-analyzer runnables support (#1898)
3da4f2bd6 lsp-capf: allow to customize filtering with incomplete completions (#1904)
392e69a50 [breadcrumb] custom segments + icons + docs (#1901)
bafb2d389 Proper spacing in breadcrumb (#1900)
f32952c53 [docs] Add breadcrumb and modeline code actions on overview
5ef8c1f58 Improve breadcrumb (#1899)
7910f4c81 Activate rust-analyzer inlay hints mode in :after-open-fn (#1897)
7e47b706a lsp-completioin-at-point: invalidate cache when the bounds-start is different (#1896)
267c10c32 Added option to skip kind in completion (#1895)
7100e254b Proposed fix for headerline icons bkg being off (#1891)
ff6c57452 lsp--capf-filtering: dont reordering the first time completed completions come (#1886)
a6122fbdc Use lsp-treemacs-symbol-icon to avoid issues with macro usage
14881db4d Create FUNDING.yml
3aad14064 [docs] remove duplicated changelog
eaa802677 [docs] Add link to opencollective
533a7899d Add FAQ entry for on demand workspace/didChangeWorkspaceFolders
458291547 Make lsp-mode a bit more robust in recurring tasks
78341db85 Revert "lsp--capf-cache: also clear cache on company completion start (#1887)" (#1888)
b7f40dc6e lsp--capf-cache: also clear cache on company completion start (#1887)
41e9a557d remove lsp-inhibit-message (#1882)
56392fb1f Move constants from lsp-tcp-server to defvars (#1881)
7ce0d789a Add all serenata supported initial config options (#1871)
961f0855d Add custom document of lsp-latex. (#1873)
3133117ec Update tramp documentation
55afaf0fe Add feature request template
10bc58ec7 Fix bug template
0610e6b02 Deleting redundant variable
fa63033bd Add lsp-serenata notification handler and init options (#1864)
162d24c86 Fix theme from get icons for breadcrumb (#1860)
09cc2c1bb Add blog section (#1865)
728134a23 Prepare 7.0 release
40719bfde Always run the cleanup to avoid stale :cancel-tokens
135d28fd6 [docs] improve lsp-auto-configure description
b0fe8082a lsp--capf-exit-fn: always clear cache when complete (#1857)
a92159954 lsp-elm/css/bash/purescript: add auto download function (#1855)
22aadd069 Enable yas-global-mode in lsp-start-plain.el
1af07584d Fix flowjs tests
58f14fed7 Proposed fix for emacs-lsp/lsp-mode#1768
a8dd37cfe lsp--capf-guess-prefix: check for empty char-before (#1856)
029ec54f7 Fix application of semantic token modifiers
70ea28f56 lsp--capf-guess-prefix: make sure the char before prefix is not word (#1844)
4c61a2a56 fix bug at lsp-sqls (#1848)
97f91274f [plists] Remove ht? usage
d42ff97dd Show actions with no kind="" in modeline (#1840)
95794efb4 Fix the logic with joining diagnostics
ddacdb658 Show message when no formatting changes are returned by LS. (#1841)
9fc9080d4 More fixes related to plists migration
8eb99dd20 Fix lens regression (#1839)
7b0b9c378 lsp-configure: allow rerun buffer configure on capabilities changes (#1837)
26eccfa56 Add LSP configuration to use sqls for SQL (#1832)
b5a124ad3 Add mouse integration to lsp-modeline-diagnotics-mode (#1836)
f163e8a3f [docs] Add lsp-diagnostic-mode image
945ceccfe Call dap-autoconfigure-mode (#1689)
e7d2c2c94 Remove extra do in docs and a bit of trailing ws (#1834)
5d15a20a5 Use find-buffer-visiting lsp--buffer-for-file (#1824)
8382cfa32 Run flycheck if diagnostics are received after the buffer is saved (#1831)
eca63bd1b Avoid downcasing paths in uri conversion code (#1820)
92b3b7526 lsp-protocol-integration: convert more ht to lsp-protocol type (#1830)
1caab8252 Update docs about path and tramp
391f3d3c8 Fix starting perl server, change perl server port (#1827)
b69f2ecc7 Configurable Rust Analyzer inlay face. (#1826)
666de5f50 Breadcrumb improvements (#1821)
a91f9b6f0 fix go-dot-mod-mode language id (#1822)
98abce187 Modify declare-function calls for breadcrumb (#1825)
114848f75 Updated changelog
67883c43d Initialization lsp-modeline-code-actions/lsp-headerline-breadcrumb
8814aa701 Fixes emacs-lsp/lsp-mode#1778
29483d9a1 lsp-diagnostics-modeline: perf improvement (#1811)
ceeabed77 lsp-copy: change definition into copy-sequence for better perf (#1816)
a8dcd9ee5 Fix type in lsp--lens-backend-fetch-missing
97275f4a6 Add lsp-copy function
890db8cf0 Hover might be null
3b6f2d150 [doc] Remove duplicated latex
a5a767d63 lsp-f-ancestor-of?: fix wrongly detection logic (#1806)
ce5fa7af0 lsp-modeline-code-action-mode: don't set/remove global-mode-string too much (#1808)
3f141c11c ci: fix gh action to triggered on pull_request too (#1809)
de5650510 Fix gh action tests on PR
bf2afe653 Fixes emacs-lsp/lsp-java#236
f3756e887 Fix copy paste error when building lsp-command-map
414a40ab8 Use lsp-keymap-prefix on code actions for modeline (#1789)
6f3035f9b Require cl-lib from lsp-protocol.el (#1802)
27b46f691 Put custom options to the right groups (#1801)
7cde47b5a Use hashtables temporary
4294d17c6 lsp-capf: wrapping initial completion items creation in while-no-input (#1794)
95c4e9b22 plists: make &<Interface?> works properly for ht
7bc548b69 Fix checkdoc
bcbc667c0 plists: fix more errors encountered by switching to lsp-protocol (#1791)
4d390a624 Optimize lsp--capf-guess-prefix (#1787)
98cbeaf9d lsp--capf-filter: optimze filtering logic and using while-no-input (#1785)
c3aba3506 lsp-rust: intergration with lsp-protocol (#1786)
925a9c8fd lsp-generate-bindings: enum should start from 1 as in specs (#1784)
782303de2 Enable plists and fix tests + byte-compile loading (#1782)
8bcf4a48b lsp-pwsh: fix initialize function to work with plists (#1783)
ff224861c [lsp-pwsh] Use lsp-protocol and plists (#1780)
c9e9d6184 Fix travis
c3742fcfd lsp-protocol: fix plist-member and test errors (#1779)
5138bfeab lsp--capf-cached-items: dont group on prefix anymore (#1774)
f725285d6 Revert changes in lsp--capf-filter-candidates
506f067f1 Fix file updates test
596166fd7 Fix lsp-protocol-test.el
fedc02a71 Fix lsp--capability
63f8f3352 Use eval-when-compile for lsp-* functions
90bef9294 Use plist-get instead of plist-get
0b16db854 Multiple fixes in plists branch
97b663945 Fix lsp--read-json for emacs 26
8a55e1bc4 Enabe plists by default
18ef17ad5 Update lsp-protocol
f692d54b4 Fix completion issue in js buffers
2eb1c3855 Fix issue in instance of methods
6cfdc22c9 Fix xref generation
9d8a230ba Fix RangeToPoint
213dcd14b [wip] Migrating lsp-mode to use lsp-protocol
b1621c5ab Add breadcrumb on headerline (#1799)
265bcc2ee Horizontal rule affects lsp-ui-doc width (#1798)
c74eb1e63 Fix gh actions duplicate runs
7b2a346e6 Remove travis integration
f89df8474 Add github action to run tests (#1795)
3e0f26c96 Fix link to installation instruction (#1796)
5d84298f2 Fix lsp-diagnose messages (#1790)
5ff64d33d Change lsp--modeline-code-actions-icon (#1788)
ed2c7810c Add modeline code actions support (#1781)
4412787dc Do not enable company if capf is disabled
5f3f9848b Update the docstring for `lsp-signature-auto-activate' (#1777)
cceafa08e Provide easier way to edit hash tables defcustom + add one for go codelens (#1766)
d52c4ede8 Fix for emacs-lsp/lsp-mode#712 (comment)
78df349a9 Cancel lenses requests per buffer. (#1776)
6f576dedd Fix signature help when using multiple language servers (#1771)
e3f172576 Fix renaming when using multiple language servers (#1769)
ff19e3623 Fix some bytecompiler warnings/gccemacs errors (#1767)
21cfcf56d Fix the order of lsp-save-restriction-and-excursion
e3ddfd356 refactor: using correct protocol name for lsp-eslint/css/haxe (#1763)
4e55f98b6 Remove metals client. (#1762)
086d8bad7 Modify declare-function calls (#1761)
865e78e5f Remove support for Theia semantic highlighting protocol (#1760)
7f62fcf8f Update org-mode docs
733f9f70e Use lsp-protocol (#1756)
ff15aa3a5 Use lsp-protocol (#1757)
19668e53d Modify declare-function calls for org-mode functions (#1758)
15e9683f5 Use lsp-protocol (#1755)
259c4afa1 Fix lsp-save-restriction-and-excursion
ad7b48915 Remove cquery from lsp-client-packages
73dbfa5f9 Initial org-mode integration (#1745)
fd6c372e9 Expand the regex for "full width" markdown elements (#1750)
b80f62fd8 document how to change lsp server when using rustic
229cec0f2 Add support for rust-analyzer "go to parent module" command
f03bf939d Remove rust-analyzer applySourceChange commands, which aren't used anymore
b88deab0d Update rust-analyzer joinLines request
38042ecc2 [docs] unify lsp-mode installation/configuration
e5165fd1f Use ranged semanticToken requests when available (#1744)
14b70b968 [docs] change separator char from readme guides
695b4b17b [docs] add doom-emacs installation
f2e2d3c15 [docs] Fix footer background color
5c9959fdf lsp--capf-filter-candidates: using our own score to sort candidates (#1726)
d5f0410a8 Fix description of lsp-diagnostics-modeline-scope
c18e8e77c Ignore timeouts from willSaveWaitUntil
3359b977f Utilization of lsp-defun/protocol bindings (ongoing)
acc885e9a Delete lsp-range pcase macro
38c7d8d61 Fixes in protocol bindings
648647371 Change Serenate priority (#1738)
cb4c5a9b3 Fix protocol warnings (#1743)
ce405d0fd Implement client side bindings for the protocol
70de64518 Do not indent after expanding snippet
be5aec102 [docs] Fix title tag for better SEO
945439a9c Remove lsp--diagnostics-modified? and trigger refresh in all buffers
9a89d6f34 Fix formatting
ebdd845ae Move customizable options back to lsp-mode group (#1733)
a16645256 Additional fixed for flycheck refactoring
fa003eb97 Rely on flycheck logic for flycheck integration
63105c710 Support semantic tokens protocol (#1721)
c0a731647 Fix lsp-eslint custom option types (#1730)
7130ffb22 Update `lsp-language-id-configuration` for FORTRAN 77 and older (#1729)
9f240113d [docs] add gdscript missing docs
06d69ea2b add missing quote (#1728)
20d3c79f3 [pyls] catch up with 0.33.0 release (#1727)
158792b57 Speed up lsp--folding-range-build-trees (#1723)
165aef756 Add fallback for flycheck error level when server does not report it (#1724)
f9e3cfa9e lsp-rust-analyzer-update-inlay-hints: make overlay advances with text
7d5424f4f Set a tooltip for the lsp--on-progress spinners (#1722)
9a42d5a82 remove code coverage badge
7da136d77 Fix clang-tidy error explanations for recent Flycheck (#1719)
3be2a19fd Add myself to the member list (#1720)
ba76fcc04 Use the spinner.el spinner for progress (#1707)
2f694b600 Change regexp for Angular language server (#1718)
02aee9277 [docs] fix JS/TS clients descriptions (#1717)
64daa90db [docs] Add mention to rustfmt on save
df1462b00 Remove Elixir (JakeBecker) support (#1715)
809c6488e Filter out non-ranges where the beginning is greater than or equal... (#1712)
5d78b6c82 lsp--completing-read: no need to take car of collections (#1711)
81d62d581 Fix mixed-up typescript server links (#1709)
a9654470a lsp-capf: restore text change + exclude trigger-chars (#1705)
93057777c [docs] Fix missing performance section
ea2d41bdf lsp-completion-at-point: fix company-prefix for trigger characters (#1703)
d6a801703 Multiple servers: finish callbacks when error (#1698)
06581a2e0 Handle nil string in lsp--render-string
17614737b lsp: using lsp-canonical-file-name instead of f-canonical when init (#1696)
be8a2e3a5 lsp-capf: support try-completions (and more) (#1693)
6db5367d9 cleanup: change to use encode-coding-string and equal (#1694)
200d6965e [pyls] catch up with v0.32.0 version of pyls (#1697)
53a52939c Disable willSave and includeText when textDocumentSync is a number (#1692)
c945014e5 Only show "truncated" if doc-lines > 0 (#1685)
bac42c50b Fix typos (#1687)
a2084bbb4 lsp--describe-buffer may have been killed (#1676)
4ff2cdbe1 [docs] fix gh action to only run on master
070aa3567 [docs] minor improvements
057e87896 rust-analyzer: add chain to rendered inlay hints
7dcaa224a [docs] Refactor docs structure
0db418066 lsp-csharp: Fix lsp-csharp-server-path option (#1675)
1c29bd4e2 [docs] Improve page title for better SEO
1dff9a24b Change Apple Sourcekit to Swift (#1679)
e1abdc757 add ess-julia-mode to language-id list (#1677)
4365f1bac Fix bug template list. (#1678)
232dd55a9 Switched redundant initialized-fn to initialization-options.  (#1671)
034ac7650 [docs] Add custom css for members section :)
5eefe2247 [docs] Refactor README to make links more visual
277b920df [docs] Migrate README from .org to .md to fix display problems on docs
b1b81a8a4 [docs] improve members front-end
2e1453d4d [docs] refactor sections on readme
35973c613 [docs] fix why section
043f380c7 [docs] fix links/bad mds/identations
2e9582708 Add Serenata lsp client (#1673)
35d463001 [docs] update installation command wrong usage of long dash (#1674)
c487bb136 Add lsp-dart to
11750e7b1 rust-analyzer: Don't update inlay hints on idle
2cc19eefa Add new metals settings. (#1667)
f10223437 lsp-capf: try to restore minimal text when completion is finalized (#1665)
4691d842c Remove unused variable. (#1666)
ebcd87b47 [docs] fix lsp-rust images path
51d960f74 lsp-capf: should not include trigger char in boundary (#1664)
54a5c7f37 [clojure] add library-folders-fn check for m2 repostiory
238c60f34 lsp-capf: properly check for trigger-chars condition (#1662)
7b7cee4d9 lsp-cafp: don't sort with incomplete list and no sort text (#1663)
f3979f6e3 [docs] fix images path
6befde587 [docs] fix images for github
afec39f8a [docs] Remove deprecated cquery
6ddb42c62 [docs] Add Google Analytics metrics
9a31334ea [docs] fix emoji plugin indentation
c68efee3b [docs] add emoji plugin
5560581e4 [docs] Fix emojis
801c9f117 [docs] Separate some sections from readme
35b869559 Case-insensitive completion for code actions (#1640)
75601cb3c [docs] fix link to languages page
f1f7a6b9b [docs] fix link to languages page
e1f879de5 [docs] fix github action
4735213a8 [docs] move readme to root of docs
8a9a3fd01 [docs] fix readme path
31d5d8f1e Change lsp-erlang-server-connection-type to symbol
de3f11b47 [docs] refactor docs migrating to a page folder
1caf3856b [docs] remove instant experimental feature
372d1a0d6 Change changelog heading
82894db82 [docs] Separate into tabs
0ac72ec8e Add auto doc generation (#1655)
6f7a35431 Fix MarkDown style link (#1656)
ec19cd825 lsp-capf: Support clangd score attribute extension (#1654)
1307e59f6 Add FAQ entry for flex filtering and emacs26
1b20877e5 doc: escape double hypen in org table (#1651)
3b4b3b03d add note to readme re how to install emacs w/native json (#1650)
3a2165888 lsp-capf: allow customize showing completion detail (#1649)
9aa0e5590 Typo: 'lsp-folding-range --> 'lsp--folding-range (#1645)
eff9e5636 lsp--auto-configure: enable yas-inhibit-overlay-modification-protection by default (#1646)
926d1024c [webpage] fix lsp-python-ms link
8e25018ef [webpage] remove beta feature 'instant'
6a5dc8480 [webpage] update links to other webpages
59d4581fb Migrate screenshots to gallery page
4aa807aa7 Move lsp-rust documentation to docs folder
945b40b4d Add setting to disable additional text edits
97a0cf9e9 Add local-webpage task to Makefile
877d69c76 Add debugger to dart doc on README
9387124fc [webpage] fix relative link
dc8f2e7a5 [webpage] Fix home and changelog links
242c88ae9 [webpage] update dap-mode link
5ff30e171 Show function prototype in the echo area when Clangd is active (#1635)
173a14456 Fixed typo in the readme
922b6d295 Update rust-analyzer settings
b79bc0643 Fix tests
bd37427c2 Introduce lsp-diagnose
86be02398 Fix broken link (#1643)
941e6062a [webpage] Add lsp-sourcekit to navaigation
78539e02c [webpage] change lsp-java link
e4462762f [webpackage] Add other Emacs-lsp packages to navigation
2de0f7a80 [webpage] add js to expanded navigation
a424dbaa1 [webpage] Add CHANGELOG and other LSPs to navigation
343db54f7 Remove stale FAQ entry
75ae98b15 Do not return deleted directory as session folder (#1641)
78294481c [webpage] Add home to navigation
bfb38ed1a Add LSPs page
8d96864b0 Add link to gitter on webpage
4da15334f Add me as member (#1638)
a332405c7 MkDocs as github page (#1637)
bdbd2d0cc Bump version to 6.3.1
9beec4b1f Replace s-replace-regexp with replace-regexp-in-string
e1ccc6ff0 add pascal to supported languages in readme (#1633)
2b4a941d5 Two small fixes for README.org (#1632)
58b731f9c Fix docs about company-lsp/company-capf
3beb749eb Update change log
1b4099283 Update Makefile (#1628)
5b1857ce8 Fix LSP Dart documentation (#1627)
d0096ccf2 Fix kotlin-language-server command (#1625)
13109e042 Add changelog link (#1624)
03f3e928a Tag 6.3
87ea1df50 do not look back on the first position in the line
d230f9cff Improve lsp-workspace-root
882cccfe6 fix typo three -> tree (#1622)
e0e85646b lsp-mode: Eliminate quadratic-time index-building for imenu. (#1616)
fe5b88366 Use pagebreaks for lsp-describe-session
a247b7023 Added links in the readme to lsp-mode related packages.
fbf69e9f3 Support bash language server glob pattern option (#1594)
5bccd6554 Use foreground, not background for unnecessary faces (#1610)
9509216b1 Add lsp-latex in readme. (#1619)
3554ea153 Do not send cancel when the request has finished
e727f9ac9 Increase lsp-idle-delay to 0.5
b449fa19f Display image on lsp--render-string. (#1612)
485d8d23d Fix typos (#1618)
9c1ab8adf Fix use (buffer-file-name) instead of buffer-file-name
4898d35ac Add some missing markdown escapes (#1614)
81b493155 Use new flycheck fringe bitmaps property if available (#1613)
f1d2cc031 Allow lsp-enable-which-key-integration to work for all modes (#1609)
85c3980f1 Perform willSaveWaitUntil sync and with shorter timeout
63d4731dd Document Rust Analyzer limitations
f3d215afe Make sure highlights are cleared before the new highlights are established
2b8f29f1f Display the first line of MarkupContent in eldoc (#1607)
d89f403fb Use when-let to simplify progress reporter code (#1603)
f39356dd5 Protect against a missing progress reporter (#1602)
b7b031f00 [#1599] Progress reporting: enable spinner if not percentage. (#1600)
3d6283f93 Update README info for company-lsp
3e0504d74 fix: golsp panicking because of % in Bazel paths (#1593)
e2d3cdfa8 Process the $/progress messages from LSP 3.15 (#1586)
5f2340e06 Add purescript-language-server (#1596)
347551b61 fix: don't unnecessarily sending nil rangeLimit (#1595)
e8e52fd4b lsp-solargraph: use bundler per project (#1589)
667112842 Do not send :only when there is no kind
f90bb8053 Allow disabling multi-root for solargraph
990b0b1f3 Activate flow language server if there is flow tag in file or .flowconfig in project (#1585)
ec6ba447d Inhibit messages during hover construction
91a4ec1a2 Followup #1579 (#1583)
e7d13396e Patch conversion when applying code actions
02275ba75 Remove lsp-dart.el (#1579)
5c94fbd04 Fix lsp-vim docstrings (#1581)
d5beefe3a Execute 'alive/'tick callbacks in current buffer (#1548)
c830f431b Fix autoload functions (#1577)
908547875 update and add new rust-analyzer customization options
06f154303 [lsp-dart] Fix kind for flutter icon (#1576)
380c55b36 [lsp-dart] Add outline and flutterOutline options (#1573)
fa21f0486 Remove dls, as deprecated (#1570)
dd490db52 Fix Issue1569 - Use lsp in cperl-mode (enhanced perl-mode) (#1575)
401d72462 Change default transport for erlang_ls to stdio (#1567)
9ded56008 Add start lsp in prog-modes in lsp-start-plain.el
c2de69cc0 Remove company-lsp in favour of company-capf in lsp-start-plain.el
31fe3c077 Add vls config `dev` and `experimental` (#1565)
cf9db8aae Fix stale lsp-semantic-highlighting name (#1556)

git-subtree-dir: pkg/lsp-mode
git-subtree-split: b9b0f349c655cc388cf1e817d71e9b9668ff0b8b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
go
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add integration test with gopls to fix json generation using symbols ibizaman/lsp-mode
4 participants
@ibizaman @yuezhu @poppyschmo @yyoncho