Show method signature when writing the arguments of the method #214
Assignees
Comments
|
I have a local change for this. If the idea sounds okay, I can send a pull request. |
|
Sure, thanks. I'll add a few |
|
What is the status of this, it doesn't seem to work as far as I can tell, but it looks like there is already some code in. Any clues towards the next step? |
|
I believe that it does not work the the optimal way. If I recall correctly you should select hover or signature but I believe that the decision should be made by the signature trigger characters that are in initialization options. |
yyoncho
added a commit
to yyoncho/lsp-mode
that referenced
this issue
Dec 16, 2018
Fixes emacs-lsp#214 - Changed eldoc message to display signature when it is present. - Replaced the message calls with lsp-message which preserves the eldoc message. At some point we may create separate buffer which will display the
yyoncho
added a commit
to yyoncho/lsp-mode
that referenced
this issue
Dec 16, 2018
Fixes emacs-lsp#214 - Changed eldoc message to display signature when it is present. - Replaced the message calls with lsp-message which preserves the eldoc message. At some point we may create separate buffer which will display the
yyoncho
added a commit
to yyoncho/lsp-mode
that referenced
this issue
Dec 17, 2018
Fixes emacs-lsp#214 - Changed eldoc message to display signature when it is present. - Replaced the message calls with lsp-message which preserves the eldoc message. At some point we may create separate buffer which will display the
yyoncho
added a commit
to yyoncho/lsp-mode
that referenced
this issue
Dec 17, 2018
Fixes emacs-lsp#214 - Changed eldoc message to display signature when it is present. - Replaced the message calls with lsp-message which preserves the eldoc message. At some point we may create separate buffer which will display the
yyoncho
added a commit
to yyoncho/lsp-mode
that referenced
this issue
Dec 17, 2018
Fixes emacs-lsp#214 - Changed eldoc message to display signature when it is present. - Replaced the message calls with lsp-message which preserves the eldoc message. At some point we may create separate buffer which will display the
yyoncho
added a commit
to yyoncho/lsp-mode
that referenced
this issue
Dec 17, 2018
Fixes emacs-lsp#214 - Changed eldoc message to display signature when it is present. - Replaced the message calls with lsp-message which preserves the eldoc message. At some point we may create separate buffer which will display the
yyoncho
added a commit
to yyoncho/lsp-mode
that referenced
this issue
Dec 19, 2018
- added `lsp-auto-require-clients` to remove the need to require lsp-clients. When set to t(default) it will autorequire lsp-clients. - `lsp` command ignores the clients which binary is not present. - `lsp` no longer throws an error when there is no client installed - `lsp` will ask which client to power on if there are multiple clients for a single mode present(also if their binary is available). This will happen each time you open a new file. In order to disable that you will have to remove the server that you do not want to run from `lsp-clients`. Later, when we solve emacs-lsp#405 we will be able to specify per project preferences like: ProjectA uses ccls, projectB uses clangd. - If you want your client to run in parallel with other server you will have to specify `:add-on?` = t when registering the client. - added 3 different message `lsp--info`, `lsp--warn` and `lsp--error` - cleanup - fixed support for tcp LANGUAGE server which apparently works only on Linux. ``` example registration (lsp-register-client (make-lsp-client :new-connection (lsp-tcp-connection (lambda (port) `("php" ,(expand-file-name "~/.composer/vendor/felixfbecker/language-server/bin/php-language-server.php") ,(format "--tcp-server=localhost:%s" port) "--memory-limit=4095M"))) :major-modes '(php-mode) :server-id 'php-ls)) ``` - Implemented signature handling in single method. Fixes emacs-lsp#214 - Changed eldoc message to display signature when it is present. - Replaced the message calls with lsp-message which preserves the eldoc message. At some point we may create separate buffer which will display the
yyoncho
added a commit
to yyoncho/lsp-mode
that referenced
this issue
Dec 20, 2018
- added `lsp-auto-require-clients` to remove the need to require lsp-clients. When set to t(default) it will autorequire lsp-clients. - `lsp` command ignores the clients which binary is not present. - `lsp` no longer throws an error when there is no client installed - `lsp` will ask which client to power on if there are multiple clients for a single mode present(also if their binary is available). This will happen each time you open a new file. In order to disable that you will have to remove the server that you do not want to run from `lsp-clients`. Later, when we solve emacs-lsp#405 we will be able to specify per project preferences like: ProjectA uses ccls, projectB uses clangd. - If you want your client to run in parallel with other server you will have to specify `:add-on?` = t when registering the client. - added 3 different message `lsp--info`, `lsp--warn` and `lsp--error` - cleanup - fixed support for tcp LANGUAGE server which apparently works only on Linux. ``` example registration (lsp-register-client (make-lsp-client :new-connection (lsp-tcp-connection (lambda (port) `("php" ,(expand-file-name "~/.composer/vendor/felixfbecker/language-server/bin/php-language-server.php") ,(format "--tcp-server=localhost:%s" port) "--memory-limit=4095M"))) :major-modes '(php-mode) :server-id 'php-ls)) ``` - Implemented signature handling in single method. Fixes emacs-lsp#214 - Changed eldoc message to display signature when it is present. - Replaced the message calls with lsp-message which preserves the eldoc message. At some point we may create separate buffer which will display the
yyoncho
added a commit
to yyoncho/lsp-mode
that referenced
this issue
Dec 20, 2018
- added `lsp-auto-require-clients` to remove the need to require lsp-clients. When set to t(default) it will autorequire lsp-clients. - `lsp` command ignores the clients which binary is not present. - `lsp` no longer throws an error when there is no client installed - `lsp` will ask which client to power on if there are multiple clients for a single mode present(also if their binary is available). This will happen each time you open a new file. In order to disable that you will have to remove the server that you do not want to run from `lsp-clients`. Later, when we solve emacs-lsp#405 we will be able to specify per project preferences like: ProjectA uses ccls, projectB uses clangd. - If you want your client to run in parallel with other server you will have to specify `:add-on?` = t when registering the client. - added 3 different message `lsp--info`, `lsp--warn` and `lsp--error` - cleanup - fixed support for tcp LANGUAGE server which apparently works only on Linux. ``` example registration (lsp-register-client (make-lsp-client :new-connection (lsp-tcp-connection (lambda (port) `("php" ,(expand-file-name "~/.composer/vendor/felixfbecker/language-server/bin/php-language-server.php") ,(format "--tcp-server=localhost:%s" port) "--memory-limit=4095M"))) :major-modes '(php-mode) :server-id 'php-ls)) ``` - Implemented signature handling in single method. Fixes emacs-lsp#214 - Changed eldoc message to display signature when it is present. - Replaced the message calls with lsp-message which preserves the eldoc message. At some point we may create separate buffer which will display the
yyoncho
added a commit
to yyoncho/lsp-mode
that referenced
this issue
Dec 20, 2018
- added `lsp-auto-require-clients` to remove the need to require lsp-clients. When set to t(default) it will autorequire lsp-clients. - `lsp` command ignores the clients which binary is not present. - `lsp` no longer throws an error when there is no client installed - `lsp` will ask which client to power on if there are multiple clients for a single mode present(also if their binary is available). This will happen each time you open a new file. In order to disable that you will have to remove the server that you do not want to run from `lsp-clients`. Later, when we solve emacs-lsp#405 we will be able to specify per project preferences like: ProjectA uses ccls, projectB uses clangd. - If you want your client to run in parallel with other server you will have to specify `:add-on?` = t when registering the client. - added 3 different message `lsp--info`, `lsp--warn` and `lsp--error` - cleanup - fixed support for tcp LANGUAGE server which apparently works only on Linux. ``` example registration (lsp-register-client (make-lsp-client :new-connection (lsp-tcp-connection (lambda (port) `("php" ,(expand-file-name "~/.composer/vendor/felixfbecker/language-server/bin/php-language-server.php") ,(format "--tcp-server=localhost:%s" port) "--memory-limit=4095M"))) :major-modes '(php-mode) :server-id 'php-ls)) ``` - Implemented signature handling in single method. Fixes emacs-lsp#214 - Changed eldoc message to display signature when it is present. - Replaced the message calls with lsp-message which preserves the eldoc message. At some point we may create separate buffer which will display the
renatofdds
pushed a commit
to renatofdds/lsp-mode
that referenced
this issue
May 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
When writing the arguments of the method, textDocument/hover method doesn't apply and there's no documentation available. However, textDocument/signatureHelp is meant exactly for this use-case. LSP client should show the signature when writing the arguments.
signatureHelp method: https://github.com/Microsoft/language-server-protocol/blob/master/protocol.md#textDocument_signatureHelp
The text was updated successfully, but these errors were encountered: