Documentation: inform straight.el users they must pull the melpa repo when upgrading to 7.0.x

[evanmoses-okta]

Describe the bug
After #2109, if a straight.el user (like me) updates lsp-mode with straight-pull-package, lsp-mode initialization will fail because clients packages aren't included in the straight build. The update to the melpa recipe addresses this, but it's not a standard operation for straight.el users to need to pull the recipe repo to update a single package.

To Reproduce
Using straight.el with an existing older lsp-mode install, run straight-update-package and restart emacs

Expected behavior
Inform users of straight.el, in the CHANGELOG an "Upgrading" section in the installation guide, that they'll need to pull melpa and lsp-mode, in that order to update to the latest version. It might be worth adding this information to the "No language server supporting X-mode found" error message that you get when attempting to run lsp. A heuristic could be if there are no clients registered.

Which Language Server did you use
lsp-go/gopls

OS
macOS 10.14.6

Error callstack
N/A

[kiennq]

I'm curious, what's the best practice for straight.el user in this case? When it installing with MELPA recipe and the recipe got updated?
@raxod502 for advices.

[ericdallo]

Good question, At the migration time we thought that change would not affect users.

[raxod502]

M-x straight-pull-package RET melpa RET. @progfolio is adding a nice command M-x straight-pull-recipe-repositories in radian-software/straight.el#576 that is more obvious in function from a user perspective. See also radian-software/straight.el#397, radian-software/straight.el#323.

I think perhaps the right way to solve this on the straight.el side (setting aside "this is not a bug" etc. etc. -- it's clearly unintuitive behavior for the end user, and creates more work for you as maintainers) would be to classify the recipe repository as a sort of pseudo-dependency of any package whose recipe was fetched from that repository. Then M-x straight-pull-package-and-dependencies, which people should already be using anyway, would pull MELPA before updating the package itself. At that point it would just be a matter of making it the default behavior to pull dependencies also.

[raxod502]

If you have any other questions, ask away. I may not have the time currently to implement required changes to straight.el, but I am certainly happy to advise.

[sejgit]

having this same issue & was starting to think I was an idiot. Was about to write a straight recipe either for each client or in my use-package for lap-mode which added the clients to the straight build (just adding the links of the clients over).