-
-
Notifications
You must be signed in to change notification settings - Fork 869
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Documentation: inform straight.el users they must pull the melpa
repo when upgrading to 7.0.x
#2179
Comments
I'm curious, what's the best practice for |
Good question, At the migration time we thought that change would not affect users. |
I think perhaps the right way to solve this on the |
If you have any other questions, ask away. I may not have the time currently to implement required changes to |
having this same issue & was starting to think I was an idiot. Was about to write a straight recipe either for each client or in my use-package for lap-mode which added the clients to the straight build (just adding the links of the clients over). |
Describe the bug
After #2109, if a
straight.el
user (like me) updateslsp-mode
withstraight-pull-package
, lsp-mode initialization will fail because clients packages aren't included in thestraight
build. The update to themelpa
recipe addresses this, but it's not a standard operation forstraight.el
users to need to pull the recipe repo to update a single package.To Reproduce
Using
straight.el
with an existing olderlsp-mode
install, runstraight-update-package
and restart emacsExpected behavior
Inform users of
straight.el
, in the CHANGELOG an "Upgrading" section in the installation guide, that they'll need to pullmelpa
andlsp-mode
, in that order to update to the latest version. It might be worth adding this information to the "No language server supporting X-mode found" error message that you get when attempting to runlsp
. A heuristic could be if there are no clients registered.Which Language Server did you use
lsp-go
/gopls
OS
macOS 10.14.6
Error callstack
N/A
The text was updated successfully, but these errors were encountered: