Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Omnisharp-Roslyn not available in the list of installable servers #3118

Closed
2 of 3 tasks
mcraveiro opened this issue Sep 23, 2021 · 5 comments
Closed
2 of 3 tasks

Omnisharp-Roslyn not available in the list of installable servers #3118

mcraveiro opened this issue Sep 23, 2021 · 5 comments
Labels

Comments

@mcraveiro
Copy link

mcraveiro commented Sep 23, 2021

Thank you for the bug report

  • I am using the latest version of lsp-mode related packages.
  • I checked FAQ and Troubleshooting sections
  • You may also try reproduce the issue using clean environment using the following command
emacs -q -l lsp-start-plain.el

where lsp-start-plain.el can be downloaded here.

Bug description

According to the documentation [1], Omnisharp-Roslyn should be available from the list of installable servers:

Installation

This Server supports automatic install. Install this language server with M-x lsp-install-server RET omnisharp RET.

Supports automatic installation.

[1] https://emacs-lsp.github.io/lsp-mode/page/lsp-csharp-omnisharp/

Steps to reproduce

With latest lsp-mode, omnisharp is not selectable from the list.

Expected behavior

omnisharp should be part of the list.

Which Language Server did you use?

Omnisharp-Roslyn [1]

[1] https://github.com/OmniSharp/omnisharp-roslyn

OS

Linux

Error callstack

No response

Anything else?

No response

@mcraveiro mcraveiro added the bug label Sep 23, 2021
@ericdallo
Copy link
Member

@mcraveiro could you try with C-u M-x lsp-install-server? we don't show the server to install when it's already installed or lsp-mode find the program in PATH

@mcraveiro
Copy link
Author

Hi @ericdallo, many thanks for the prompt reply, I was just about to update the ticket! :-) this is exactly the problem, the server was already installed but for some reason its not kicking in when I open up a C# file. I've uninstalled the server and then it correctly showed up on the list. Perhaps it would be nice to show installed servers with a comment ("already installed")?

@ericdallo
Copy link
Member

Yeah, you are not the first one suggesting that, IMO we can show that and lsp-mode just force install if user select that.
WDYT @yyoncho ?

@mcraveiro
Copy link
Author

Argh, can you believe it, I was calling (lsp-mode) in my C# hooks instead of (lsp). Typical user error! :-) all working now, thanks!

@mcraveiro
Copy link
Author

Yeah, you are not the first one suggesting that, IMO we can show that and lsp-mode just force install if user select that.
WDYT @yyoncho ?

Ah actually that is a very nice idea! I mean you can just show omnisharp in the list of servers, and when the user selects it you could ask: "server is already installed, would you like to reinstall?" This would be very helpful in cases such as mine methinks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants